Request - Make the startupProbe behavior consistent with liveness and readiness

[tfitzgerald-sesame]

Issue

Currently the startupProbe defined in values.yaml only gets applied to the deployment_backend template while the livenessProbe and readinessProbe values are applied to the deployment_backend, deployment_code_executor, deployment_dbconnector, deployment_jobs, deployment_multiplayer_ws and deployment_workflows templates.

We run into issues where the workflow deployment would benefit from a startupProbe but since it doesn't get applied our only option is to either increase the livenessProbe initialDelay (which affects all deployments) or wait and hope it stabilizes.

Request

Could the startupProbe also be applied to those same templates to bring consistency across the probes?

Proposed Solution

Add the code block below to the remaining deployment_*** templates

{{- if .Values.startupProbe.enabled }}
        startupProbe:
          httpGet:
            path: {{ .Values.startupProbe.path }}
            port: {{ .Values.service.internalPort }}
          initialDelaySeconds: {{ .Values.startupProbe.initialDelaySeconds }}
          timeoutSeconds: {{ .Values.startupProbe.timeoutSeconds }}
          successThreshold: {{ .Values.startupProbe.successThreshold }}
          periodSeconds: {{ .Values.startupProbe.periodSeconds }}
{{- end }}