Skip to content

Commit e528141

Browse files
committed
Improve matching of . in Javadocs (#976)
JabRef/jabref-koppor#716 jabgui/src/main/java/org/jabref/gui/desktop/os/NativeDesktop.java jablib/src/main/java/org/jabref/logic/importer/SearchBasedParserFetcher.java jablib/src/main/java/org/jabref/logic/importer/Importer.java jablib/src/main/java/org/jabref/model/database/BibDatabaseContext.java
1 parent 2246136 commit e528141

File tree

1 file changed

+20
-16
lines changed

1 file changed

+20
-16
lines changed

src/main/java/gr/uom/java/xmi/diff/UMLJavadocDiff.java

Lines changed: 20 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -425,7 +425,7 @@ private boolean processModifiedTags(UMLTagElement tagBefore, UMLTagElement tagAf
425425
}
426426
}
427427
}
428-
if(!matchFound) {
428+
if(!matchFound && beforeMatchingIndices.size() == matchingIndices.size()) {
429429
for(Integer index : matchingIndices) {
430430
if(!alreadyMatchedDocElement(docElement, fragmentsAfter.get(index))) {
431431
Pair<UMLDocElement, UMLDocElement> pair = Pair.of(docElement, fragmentsAfter.get(index));
@@ -513,7 +513,7 @@ private boolean processModifiedTags(UMLTagElement tagBefore, UMLTagElement tagAf
513513
}
514514
}
515515
}
516-
if(!matchFound) {
516+
if(!matchFound && afterMatchingIndices.size() == matchingIndices.size()) {
517517
for(Integer index : matchingIndices) {
518518
if(!alreadyMatchedDocElement(fragmentsBefore.get(index), docElement)) {
519519
Pair<UMLDocElement, UMLDocElement> pair = Pair.of(fragmentsBefore.get(index), docElement);
@@ -550,27 +550,31 @@ private boolean processModifiedTags(UMLTagElement tagBefore, UMLTagElement tagAf
550550
if(deletedDocElements.size() <= addedDocElements.size()) {
551551
for(UMLDocElement deletedDocElement : new ArrayList<>(deletedDocElements)) {
552552
String trimmed1 = deletedDocElement.getText().replaceAll("^\"|\"$", "");
553-
for(UMLDocElement addedDocElement : new ArrayList<>(addedDocElements)) {
554-
String trimmed2 = addedDocElement.getText().replaceAll("^\"|\"$", "");
555-
if(trimmed1.equals(trimmed2) || trimmed1.equals(trimmed2 + ".") || trimmed2.equals(trimmed1 + ".")) {
556-
Pair<UMLDocElement, UMLDocElement> pair = Pair.of(deletedDocElement, addedDocElement);
557-
commonDocElements.add(pair);
558-
deletedDocElements.remove(deletedDocElement);
559-
addedDocElements.remove(addedDocElement);
553+
if(!trimmed1.equals(".")) {
554+
for(UMLDocElement addedDocElement : new ArrayList<>(addedDocElements)) {
555+
String trimmed2 = addedDocElement.getText().replaceAll("^\"|\"$", "");
556+
if(trimmed1.equals(trimmed2) || trimmed1.equals(trimmed2 + ".") || trimmed2.equals(trimmed1 + ".")) {
557+
Pair<UMLDocElement, UMLDocElement> pair = Pair.of(deletedDocElement, addedDocElement);
558+
commonDocElements.add(pair);
559+
deletedDocElements.remove(deletedDocElement);
560+
addedDocElements.remove(addedDocElement);
561+
}
560562
}
561563
}
562564
}
563565
}
564566
else {
565567
for(UMLDocElement addedDocElement : new ArrayList<>(addedDocElements)) {
566568
String trimmed2 = addedDocElement.getText().replaceAll("^\"|\"$", "");
567-
for(UMLDocElement deletedDocElement : new ArrayList<>(deletedDocElements)) {
568-
String trimmed1 = deletedDocElement.getText().replaceAll("^\"|\"$", "");
569-
if(trimmed1.equals(trimmed2) || trimmed1.equals(trimmed2 + ".") || trimmed2.equals(trimmed1 + ".")) {
570-
Pair<UMLDocElement, UMLDocElement> pair = Pair.of(deletedDocElement, addedDocElement);
571-
commonDocElements.add(pair);
572-
deletedDocElements.remove(deletedDocElement);
573-
addedDocElements.remove(addedDocElement);
569+
if(!trimmed2.equals(".")) {
570+
for(UMLDocElement deletedDocElement : new ArrayList<>(deletedDocElements)) {
571+
String trimmed1 = deletedDocElement.getText().replaceAll("^\"|\"$", "");
572+
if(trimmed1.equals(trimmed2) || trimmed1.equals(trimmed2 + ".") || trimmed2.equals(trimmed1 + ".")) {
573+
Pair<UMLDocElement, UMLDocElement> pair = Pair.of(deletedDocElement, addedDocElement);
574+
commonDocElements.add(pair);
575+
deletedDocElements.remove(deletedDocElement);
576+
addedDocElements.remove(addedDocElement);
577+
}
574578
}
575579
}
576580
}

0 commit comments

Comments
 (0)