Skip to content

Enforce Include All LBRN Layers and Remove Inclusion Toggles #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AnasSarkiz merged 1 commit into from
Jan 28, 2026
Merged

Enforce Include All LBRN Layers and Remove Inclusion Toggles #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
124 changes: 2 additions & 122 deletions lib/components/settings-panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import React, { useState, useRef, useCallback } from "react"

import { Button } from "@/components/ui/button"
import { Separator } from "@/components/ui/separator"
import { Cpu, Layers, Settings, Target, Upload, Zap } from "lucide-react"
import { Cpu, Layers, Settings, Upload, Zap } from "lucide-react"
import { useWorkspace } from "./workspace-context"

export function SettingsPanel() {
Expand Down Expand Up @@ -132,29 +132,6 @@ export function SettingsPanel() {
await processCircuitFile(files[0])
}
}
// Helper function to create toggle buttons
const ToggleButton = ({
value,
onChange,
label,
}: {
value: boolean
onChange: (value: boolean) => void
label: string
}) => (
<div className="flex items-center justify-between min-w-0">
<span className="text-sm truncate">{label}</span>
<Button
variant={value ? "default" : "outline"}
size="sm"
onClick={() => onChange(!value)}
className="w-16"
>
{value ? "On" : "Off"}
</Button>
</div>
)

// Helper function for numeric controls
const NumericControl = ({
value,
Expand Down Expand Up @@ -284,107 +261,10 @@ export function SettingsPanel() {
</div>
</div>

<Separator />

{/* Basic Settings Section */}
<div className="space-y-3">
<div className="flex items-center gap-2">
<Layers className="size-4" />
<h4 className="text-sm font-medium">Basic Settings</h4>
</div>
<div className="space-y-3 pl-6">
<ToggleButton
value={lbrnOptions.includeCopper ?? true}
onChange={(value) =>
setLbrnOptions({ ...lbrnOptions, includeCopper: value })
}
label="Include Copper"
/>
<ToggleButton
value={lbrnOptions.includeSoldermask ?? false}
onChange={(value) =>
setLbrnOptions({ ...lbrnOptions, includeSoldermask: value })
}
label="Include Soldermask"
/>
<ToggleButton
value={lbrnOptions.includeCopperCutFill ?? false}
onChange={(value) =>
setLbrnOptions({ ...lbrnOptions, includeCopperCutFill: value })
}
label="Include Copper Cut Fill"
/>
{/* Layer Selection */}
<div className="flex items-center justify-between">
<span className="text-sm">Layers</span>
<div className="flex gap-1">
<Button
variant={
(lbrnOptions.includeLayers ?? ["top", "bottom"]).includes(
"top",
)
? "default"
: "outline"
}
size="sm"
className="w-16"
onClick={() =>
setLbrnOptions({
...lbrnOptions,
includeLayers: (
lbrnOptions.includeLayers ?? ["top", "bottom"]
).includes("top")
? (lbrnOptions.includeLayers ?? ["top", "bottom"]).filter(
(l: "top" | "bottom") => l !== "top",
)
: [
...(lbrnOptions.includeLayers ?? ["top", "bottom"]),
"top",
],
})
}
>
Top
</Button>
<Button
variant={
(lbrnOptions.includeLayers ?? ["top", "bottom"]).includes(
"bottom",
)
? "default"
: "outline"
}
size="sm"
className="w-16"
onClick={() =>
setLbrnOptions({
...lbrnOptions,
includeLayers: (
lbrnOptions.includeLayers ?? ["top", "bottom"]
).includes("bottom")
? (lbrnOptions.includeLayers ?? ["top", "bottom"]).filter(
(l: "top" | "bottom") => l !== "bottom",
)
: [
...(lbrnOptions.includeLayers ?? ["top", "bottom"]),
"bottom",
],
})
}
>
Bottom
</Button>
</div>
</div>
</div>
</div>

<Separator />

{/* Advanced Settings Section */}
<div className="space-y-3">
<div className="flex items-center gap-2">
<Target className="size-4" />
<Layers className="size-4" />
<h4 className="text-sm font-medium">Advanced Settings</h4>
</div>
<div className="space-y-3 pl-6">
Expand Down
16 changes: 12 additions & 4 deletions lib/components/workspace-context.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,9 @@ export function WorkspaceProvider({ children }: { children: ReactNode }) {
const [lbrnOptions, setLbrnOptionsState] =
useState<ConvertCircuitJsonToLbrnOptions>({
includeCopper: true,
includeSoldermask: false,
includeSilkscreen: false,
includeCopperCutFill: false,
includeSoldermask: true,
includeSilkscreen: true,
includeCopperCutFill: true,
includeLayers: ["top", "bottom"],
laserSpotSize: 0.005,
traceMargin: 0,
Expand All @@ -84,7 +84,15 @@ export function WorkspaceProvider({ children }: { children: ReactNode }) {
const setLbrnOptions = (
options: Partial<ConvertCircuitJsonToLbrnOptions>,
) => {
setLbrnOptionsState((prev) => ({ ...prev, ...options }))
setLbrnOptionsState((prev) => ({
...prev,
...options,
includeCopper: true,
includeSoldermask: true,
includeSilkscreen: true,
includeCopperCutFill: true,
includeLayers: ["top", "bottom"],
}))
}

// Auto-convert to LBRN when circuit is loaded
Expand Down