Refactor solver name retrieval to use getSolverName() method for consistency (#17)

Author: Ayushjhawar8

lib/BaseSolver.ts

@@ -24,6 +24,10 @@ export class BaseSolver {
   stats: Record<string, any> = {}
   _setupDone = false
 
+  getSolverName(): string {
+    return this.constructor.name
+  }
+
   setup() {
     if (this._setupDone) return
     this._setup()
@@ -44,15 +48,15 @@ export class BaseSolver {
     try {
       this._step()
     } catch (e) {
-      this.error = `${this.constructor.name} error: ${e}`
+      this.error = `${this.getSolverName()} error: ${e}`
       this.failed = true
       throw e
     }
     if (!this.solved && this.iterations >= this.MAX_ITERATIONS) {
       this.tryFinalAcceptance()
     }
     if (!this.solved && this.iterations >= this.MAX_ITERATIONS) {
-      this.error = `${this.constructor.name} ran out of iterations`
+      this.error = `${this.getSolverName()} ran out of iterations`
       this.failed = true
     }
     if ("computeProgress" in this) {

lib/react/DownloadDropdown.tsx

@@ -49,7 +49,7 @@ export const DownloadDropdown = ({
     try {
       if (typeof solver.getConstructorParams !== "function") {
         alert(
-          `getConstructorParams() is not implemented for ${solver.constructor.name}`,
+          `getConstructorParams() is not implemented for ${solver.getSolverName()}`,
         )
         return
       }
@@ -63,12 +63,12 @@ export const DownloadDropdown = ({
       const url = URL.createObjectURL(blob)
       const a = document.createElement("a")
       a.href = url
-      a.download = `${solver.constructor.name}_params.json`
+      a.download = `${solver.getSolverName()}_params.json`
       a.click()
       URL.revokeObjectURL(url)
     } catch (error) {
       alert(
-        `Error downloading params for ${solver.constructor.name}: ${error instanceof Error ? error.message : String(error)}`,
+        `Error downloading params for ${solver.getSolverName()}: ${error instanceof Error ? error.message : String(error)}`,
       )
     }
     setIsOpen(false)
@@ -79,7 +79,7 @@ export const DownloadDropdown = ({
       const params = deepRemoveUnderscoreProperties(
         solver.getConstructorParams(),
       )
-      const solverName = solver.constructor.name
+      const solverName = solver.getSolverName()
       const isSchematicTracePipelineSolver =
         solverName === "SchematicTracePipelineSolver"
 
@@ -118,7 +118,7 @@ export default () => {
       URL.revokeObjectURL(url)
     } catch (error) {
       alert(
-        `Error generating page.tsx for ${solver.constructor.name}: ${error instanceof Error ? error.message : String(error)}`,
+        `Error generating page.tsx for ${solver.getSolverName()}: ${error instanceof Error ? error.message : String(error)}`,
       )
     }
     setIsOpen(false)
@@ -129,7 +129,7 @@ export default () => {
       const params = deepRemoveUnderscoreProperties(
         solver.getConstructorParams(),
       )
-      const solverName = solver.constructor.name
+      const solverName = solver.getSolverName()
 
       const content = `import { ${solverName} } from "lib/solvers/${solverName}/${solverName}"
 import { test, expect } from "bun:test"
@@ -156,7 +156,7 @@ test("${solverName} should solve problem correctly", () => {
       URL.revokeObjectURL(url)
     } catch (error) {
       alert(
-        `Error generating test.ts for ${solver.constructor.name}: ${error instanceof Error ? error.message : String(error)}`,
+        `Error generating test.ts for ${solver.getSolverName()}: ${error instanceof Error ? error.message : String(error)}`,
       )
     }
     setIsOpen(false)
@@ -167,9 +167,9 @@ test("${solverName} should solve problem correctly", () => {
       <button
         className="px-2 py-1 rounded text-xs cursor-pointer"
         onClick={() => setIsOpen(!isOpen)}
-        title={`Download options for ${solver.constructor.name}`}
+        title={`Download options for ${solver.getSolverName()}`}
       >
-        {solver.constructor.name}
+        {solver.getSolverName()}
       </button>
 
       {isOpen && (

lib/react/SolverBreadcrumbInputDownloader.tsx

@@ -21,7 +21,7 @@ export const SolverBreadcrumbInputDownloader = ({
   return (
     <div className="flex gap-1 items-center text-sm pt-1">
       {solverChain.map((s, index) => (
-        <div key={s.constructor.name} className="flex items-center">
+        <div key={s.getSolverName()} className="flex items-center">
           {index > 0 && <span className="text-gray-400 mx-1">→</span>}
           <DownloadDropdown solver={s} />
         </div>