fix: support recursive directory deletion in file manager#3066
Open
bitsbyritik wants to merge 3 commits intotscircuit:mainfrom
Open
fix: support recursive directory deletion in file manager#3066bitsbyritik wants to merge 3 commits intotscircuit:mainfrom
bitsbyritik wants to merge 3 commits intotscircuit:mainfrom
Conversation
imrishabh18
requested changes
Mar 27, 2026
Member
imrishabh18
left a comment
imrishabh18
left a comment
There was a problem hiding this comment.
I think it's not quite readable, create a new hook deleteFilesFromDirectory and that should be handling the deletion of directories
imrishabh18
requested changes
Mar 28, 2026
Member
imrishabh18
left a comment
imrishabh18
left a comment
There was a problem hiding this comment.
The logic for deleting directory is incorrect.
-> 1 (dir 1)
-> 2 (dir 2)
-> 3 (example.tsx)
If I delete (dir 2), I see that the dir 1 is also removed from the tree.
Author
|
https://www.loom.com/share/4f9ef428bbf54935bf37c0a943a9c527 kindly re-verify if we are deleting dir2 and no files left in dir1 then only dir1 is deleting |
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/fix #3065
https://www.loom.com/share/59170d133b23482ebabf549003c3f2eb