build: add type checking (#155)

tscpp · web-flow · commit 4490904c6987 · 2024-06-26T11:56:56.000+02:00
diff --git a/.github/workflows/checks.yml b/.github/workflows/checks.yml
@@ -122,3 +122,28 @@ jobs:
 
       - name: Check Format
         run: pnpm exec prettier --check .
+
+  type-check:
+    name: Type Check
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout Repository (deep)
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+
+      - uses: pnpm/action-setup@v3
+        with:
+          version: 9
+
+      - name: Setup Node.js 20.x
+        uses: actions/setup-node@v3
+        with:
+          node-version: 20.x
+          cache: pnpm
+
+      - name: Install
+        run: pnpm install --frozen-lockfile
+
+      - name: Type Check
+        run: pnpm run type-check
diff --git a/package.json b/package.json
@@ -23,6 +23,7 @@
   },
   "devDependencies": {
     "@eslint/js": "^9.0.0",
+    "@jest/globals": "^29.7.0",
     "@microsoft/api-extractor": "^7.43.1",
     "@nx/eslint": "19.2.2",
     "@nx/jest": "19.2.2",
@@ -41,7 +42,6 @@
     "@tools/tsconfig": "workspace:*",
     "@trivago/prettier-plugin-sort-imports": "^4.3.0",
     "@types/bun": "1.1.0",
-    "@types/jest": "^29.4.0",
     "@types/node": "20.12.7",
     "@vitest/ui": "^1.3.1",
     "conventional-versioning": "0.2.0-rc.8",
diff --git a/packages/analyzer/tsconfig.json b/packages/analyzer/tsconfig.json
diff --git a/packages/cli/src/logger.spec.ts b/packages/cli/src/logger.spec.ts
@@ -1,4 +1,5 @@
 import { LogFormatter, LogLevel, LogUncolorize, Logger } from "./logger.js";
+import { it, describe, expect } from "@jest/globals";
 import chalk from "chalk";
 import assert from "node:assert/strict";
 
diff --git a/packages/fabricator/src/chunk.spec.ts b/packages/fabricator/src/chunk.spec.ts
@@ -1,4 +1,5 @@
 import { Chunk } from "./chunk.js";
+import { it, describe, expect } from "@jest/globals";
 import { Range } from "@knuckles/location";
 
 describe("Chunk", () => {
diff --git a/packages/fabricator/src/location.spec.ts b/packages/fabricator/src/location.spec.ts
@@ -1,4 +1,5 @@
 import { DynamicPosition, DynamicRange } from "./location.js";
+import { it, describe, expect } from "@jest/globals";
 
 describe("DynamicPosition", () => {
   it("translates position", () => {
diff --git a/packages/fabricator/src/mapping.spec.ts b/packages/fabricator/src/mapping.spec.ts
@@ -1,4 +1,5 @@
 import { Chunk } from "./chunk.js";
+import { it, describe, expect } from "@jest/globals";
 import { Range } from "@knuckles/location";
 import assert from "node:assert/strict";
 
diff --git a/packages/fabricator/src/marker.spec.ts b/packages/fabricator/src/marker.spec.ts
@@ -1,4 +1,5 @@
 import { Chunk } from "./chunk.js";
+import { it, describe, expect } from "@jest/globals";
 
 describe("Marker", () => {
   it("remembers marker position", () => {
diff --git a/packages/fabricator/src/snapshot.spec.ts b/packages/fabricator/src/snapshot.spec.ts
@@ -1,5 +1,6 @@
 import { Chunk } from "./chunk.js";
 import { type Snapshot } from "./snapshot.js";
+import { it, describe, expect, beforeAll } from "@jest/globals";
 import { Position, Range } from "@knuckles/location";
 
 describe("Snapshot", () => {
diff --git a/packages/fabricator/src/tracker.spec.ts b/packages/fabricator/src/tracker.spec.ts
@@ -1,4 +1,5 @@
 import { Chunk } from "./chunk.js";
+import { it, describe, expect } from "@jest/globals";
 
 describe("Tracker", () => {
   it("tracks changes", () => {
diff --git a/packages/location/src/position.spec.ts b/packages/location/src/position.spec.ts
@@ -1,4 +1,5 @@
 import Position from "./position.js";
+import { it, describe, expect } from "@jest/globals";
 
 describe("Position", () => {
   it("Converts offset to position using LF", () => {
diff --git a/packages/parser/src/parser.test.ts b/packages/parser/src/parser.test.ts
@@ -1,4 +1,5 @@
 import { parse } from "./parse.js";
+import { test, describe, expect } from "@jest/globals";
 
 describe("parser", () => {
   test("Deep virtual elements", () => {
diff --git a/packages/ssr/test/binding-context.test.ts b/packages/ssr/test/binding-context.test.ts
@@ -1,4 +1,5 @@
 import { html, render } from "./common.js";
+import { test, describe } from "@jest/globals";
 import assert from "node:assert/strict";
 
 describe("binding context", () => {
diff --git a/packages/ssr/test/eval.test.ts b/packages/ssr/test/eval.test.ts
@@ -1,4 +1,5 @@
 import { transform } from "../src/evaluate.js";
+import { test, describe } from "@jest/globals";
 import assert from "node:assert/strict";
 
 describe("evaluation", () => {
diff --git a/packages/ssr/test/non-strict.test.ts b/packages/ssr/test/non-strict.test.ts
@@ -1,4 +1,5 @@
 import { html, render } from "./common.js";
+import { test, describe } from "@jest/globals";
 import assert from "node:assert/strict";
 
 describe("non-strict", () => {
diff --git a/packages/ssr/test/rollup.test.ts b/packages/ssr/test/rollup.test.ts
@@ -1,4 +1,5 @@
 import knockoutSSR from "../src/rollup/plugin.js";
+import { test, describe } from "@jest/globals";
 import assert from "node:assert/strict";
 import { rollup } from "rollup";
 
diff --git a/packages/ssr/test/ssr.test.ts b/packages/ssr/test/ssr.test.ts
@@ -1,5 +1,6 @@
 import * as ssr from "../src/node/index.js";
 import { html, render } from "./common.js";
+import { test, describe } from "@jest/globals";
 import assert from "node:assert/strict";
 
 describe("server-side rendering", () => {
diff --git a/packages/ssr/test/webpack.test.ts b/packages/ssr/test/webpack.test.ts
@@ -1,3 +1,4 @@
+import { test, describe } from "@jest/globals";
 import { createFsFromVolume, Volume } from "memfs";
 import assert from "node:assert/strict";
 import webpack from "webpack";
@@ -33,7 +34,7 @@ describe("webpack (build-tool)", () => {
           return done(err);
         }
 
-        const close = (err?: unknown) => {
+        const close = (err?: any) => {
           compiler.close((closeErr) => {
             if (err) {
               return done(err);
diff --git a/packages/typescript/tsconfig.json b/packages/typescript/tsconfig.json
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/tools/tsconfig/jest.json b/tools/tsconfig/jest.json
@@ -1,7 +1,6 @@
 {
   "extends": "./node.json",
   "compilerOptions": {
-    "types": ["jest", "node"],
     "verbatimModuleSyntax": false,
     "moduleDetection": "force",
     "moduleResolution": "Bundler",

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`import { LogFormatter, LogLevel, LogUncolorize, Logger } from "./logger.js";`
	`2`	`+import { it, describe, expect } from "@jest/globals";`
`2`	`3`	`import chalk from "chalk";`
`3`	`4`	`import assert from "node:assert/strict";`
`4`	`5`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`import { Chunk } from "./chunk.js";`
	`2`	`+import { it, describe, expect } from "@jest/globals";`
`2`	`3`	`import { Range } from "@knuckles/location";`
`3`	`4`
`4`	`5`	`describe("Chunk", () => {`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`import { DynamicPosition, DynamicRange } from "./location.js";`
	`2`	`+import { it, describe, expect } from "@jest/globals";`
`2`	`3`
`3`	`4`	`describe("DynamicPosition", () => {`
`4`	`5`	`it("translates position", () => {`