Skip to content

Use correct names for syntax highlighting grammar #8

@tscpp

Description

@tscpp

As of today (1de6414), the syntax highlighting grammar uses incorrect scope names to color the check boxes. For example, is the scope name storage.type.xit even remotely close to being a correct name for ongoing check boxes? No.

While this works for some themes, it can look really confusing in some themes:

There are however a few things to note, mainly being:

  1. No theme is or should be configured to work specifically with xit.
  2. Configuring the colors for the rules manually should be avoided because of inconvenience for the user.
  3. Colors will look differently in different themes.

Possible solutions would be to:

  1. Use semantic highlighting with explicit colors which could be a bad approach for themes that use a light, red, blue, etc. background.
  2. Use scopes which can be considered correct and who don't have similar color of different scopes. This can be used in combination with optional user configuration

The issue is open for other solutions

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions