refactor: implement reset method in CliPlatformTest to clear static collections and prevent memory leaks

Author: Romakita

packages/cli-plugin-eslint/package.json

@@ -17,7 +17,9 @@
   },
   "scripts": {
     "build": "yarn build:ts",
-    "build:ts": "tsc --build tsconfig.esm.json"
+    "build:ts": "tsc --build tsconfig.esm.json",
+    "/test": "vitest run",
+    "/test:ci": "vitest run --coverage.thresholds.autoUpdate=true"
   },
   "devDependencies": {
     "@tsed/cli": "workspace:*",

packages/cli-plugin-eslint/src/hooks/EslintInitHook.ts

@@ -1,14 +1,11 @@
-import {type CliCommandHooks, type InitCmdContext, render, type RenderDataContext, type RenderOptions} from "@tsed/cli";
+import {type CliCommandHooks, type InitCmdContext, render, type RenderDataContext} from "@tsed/cli";
 import {PackageManagersModule, ProjectPackageJson, type Task} from "@tsed/cli-core";
 import {inject, injectable} from "@tsed/di";
 
 import {TEMPLATE_DIR} from "../utils/templateDir.js";
 
 export class EslintInitHook implements CliCommandHooks {
-  $alterRenderFiles(
-    files: (string | RenderOptions)[],
-    data: RenderDataContext
-  ): (string | RenderOptions)[] | Promise<(string | RenderOptions)[]> {
+  $alterRenderFiles(files: string[], data: RenderDataContext) {
     if (!data.eslint) {
       return files;
     }
@@ -28,11 +25,11 @@ export class EslintInitHook implements CliCommandHooks {
         .filter(Boolean)
         .map((path) => {
           return {
-            path,
-            templateDir: `${TEMPLATE_DIR}/init`
+            id: "/" + path,
+            from: `${TEMPLATE_DIR}/init`
           };
         })
-    ] as (string | RenderOptions)[];
+    ];
   }
 
   $alterPackageJson(packageJson: ProjectPackageJson, data: RenderDataContext): ProjectPackageJson | Promise<ProjectPackageJson> {

packages/cli-plugin-eslint/test/init.integration.spec.ts

@@ -25,6 +25,7 @@ describe("Eslint: Init cmd", () => {
 
     await CliPlatformTest.initProject({
       eslint: true,
+      lintstaged: true,
       prettier: true
     });
 
@@ -34,6 +35,14 @@ describe("Eslint: Init cmd", () => {
         "project-name/.barrels.json",
         "project-name/.dockerignore",
         "project-name/.gitignore",
+        "project-name/.husky/.gitignore",
+        "project-name/.husky/_/.gitignore",
+        "project-name/.husky/_/husky.sh",
+        "project-name/.husky/post-commit",
+        "project-name/.husky/pre-commit",
+        "project-name/.lintstagedrc.json",
+        "project-name/.prettierignore",
+        "project-name/.prettierrc",
         "project-name/.swcrc",
         "project-name/Dockerfile",
         "project-name/README.md",
@@ -60,6 +69,7 @@ describe("Eslint: Init cmd", () => {
         "yarn install",
         "yarn add --ignore-engines @tsed/logger @tsed/engines @tsed/barrels ajv cross-env dotenv dotenv-expand dotenv-flow @swc/core @swc/cli @swc/helpers @swc-node/register typescript body-parser cors compression cookie-parser express method-override",
         "yarn add -D --ignore-engines @types/node @types/multer tslib nodemon @types/cors @types/express @types/compression @types/cookie-parser @types/method-override",
+        "yarn run prepare",
         "yarn run test:lint:fix",
         "yarn run barrels",
       ]

packages/cli-plugin-oidc-provider/src/hooks/OidcProviderInitHook.ts

@@ -1,13 +1,11 @@
-import {join} from "node:path";
-
 import {type CliCommandHooks, ProjectClient, render, type RenderDataContext} from "@tsed/cli";
 import {injectable} from "@tsed/di";
 import {SyntaxKind} from "ts-morph";
 
 import {TEMPLATE_DIR} from "../utils/templateDir.js";
 
 export class OidcProviderInitHook implements CliCommandHooks {
-  $alterRenderFiles(files: string[], data: RenderDataContext): string[] {
+  $alterRenderFiles(files: string[], data: RenderDataContext) {
     if (!data.oidc) {
       return files;
     }
@@ -37,11 +35,16 @@ export class OidcProviderInitHook implements CliCommandHooks {
         "/views/select_account.ejs"
       ]
         .filter(Boolean)
-        .map((path: string) => join(TEMPLATE_DIR, path))
+        .map((path: string) => {
+          return {
+            id: path,
+            from: TEMPLATE_DIR
+          };
+        })
     ];
   }
 
-  async $alterProjectFiles(project: ProjectClient, data: RenderDataContext): ProjectClient {
+  async $alterProjectFiles(project: ProjectClient, data: RenderDataContext) {
     if (!data.oidc) {
       return project;
     }

packages/cli/src/interfaces/AlterRenderFiles.ts

@@ -1,5 +1,8 @@
 import type {RenderDataContext} from "./RenderDataContext.js";
 
 export interface AlterRenderFiles {
-  $alterRenderFiles(files: string[], data: RenderDataContext): string[] | Promise<string[]>;
+  $alterRenderFiles(
+    files: string[],
+    data: RenderDataContext
+  ): (string | {id: string; from: string})[] | Promise<(string | {id: string; from: string})[]>;
 }

vitest.config.mts

@@ -3,7 +3,7 @@ import {defineConfig} from "vitest/config";
 export default defineConfig({
   test: {
     projects: [
-      'packages/**/vitest.config.{mts,ts}'
-    ]
+      "packages/**/vitest.config.{mts,ts}"
+    ],
   }
 })