Indeterminate PreparedStatement error hidden when inside a transaction (eclipse-vertx#1558) (eclipse-vertx#1559)

See eclipse-vertx#1557

When inside a transaction (autocommit=false), don't try to prepare a statement again, even if the error is due to indeterminate types.

Indeed, the transaction is aborted and new commands are ignored until the transaction is rollbacked.

Signed-off-by: Thomas Segismont <[email protected]>

Author: tsegismont

vertx-pg-client/src/test/java/io/vertx/tests/pgclient/PreparedStatementTestBase.java

@@ -547,6 +547,14 @@ private <T> void testInferDataType42P18(TestContext ctx, Class<T> type, T value,
           ctx.assertEquals("HELLO " + suffix2, str);
         }));
     }));
+    PgConnection.connect(vertx, options()).onComplete(ctx.asyncAssertSuccess(conn -> {
+      conn.begin()
+        .flatMap(tx -> conn.preparedQuery("SELECT CONCAT('HELLO ', $1)").execute(Tuple.of(value))
+          .eventually(() -> conn.close())
+          .onComplete(ctx.asyncAssertFailure(failure -> {
+            ctx.assertTrue(hasSqlstateCode(failure, "42P18"));
+          })));
+    }));
   }
 
   @Test

vertx-sql-client/src/main/java/io/vertx/sqlclient/impl/SocketConnectionBase.java

@@ -295,7 +295,7 @@ private PrepareStatementCommand prepareCommand(ExtendedQueryCommand<?> queryCmd,
           ctx.flush();
         }
       } else {
-        if (isIndeterminatePreparedStatementError(cause) && !sendParameterTypes) {
+        if (queryCmd.autoCommit() && isIndeterminatePreparedStatementError(cause) && !sendParameterTypes) {
           ChannelHandlerContext ctx = socket.channelHandlerContext();
           // We cannot cache this prepared statement because it might be executed with another type
           ctx.write(prepareCommand(queryCmd, false, true), ctx.voidPromise());

vertx-sql-client/src/main/java/io/vertx/sqlclient/internal/SqlConnectionBase.java

@@ -80,7 +80,7 @@ public Future<PreparedStatement> prepare(String sql, PrepareOptions options) {
       .compose(
       cr -> Future.succeededFuture(PreparedStatementBase.create(conn, context, cr, autoCommit())),
       err -> {
-        if (conn.isIndeterminatePreparedStatementError(err)) {
+        if (autoCommit() && conn.isIndeterminatePreparedStatementError(err)) {
           return Future.succeededFuture(PreparedStatementBase.create(conn, context, options, sql, autoCommit()));
         } else {
           return Future.failedFuture(err);