Remove unnecessary asserts

Author: nspope

tsdate/approx.py

@@ -111,15 +111,15 @@ def sufficient_statistics(a_i, b_i, a_j, b_j, y_ij, mu_ij):
 
     :return: normalizing constant, E[t_i], E[log t_i], E[t_j], E[log t_j]
     """
-    assert a_i > 0 and b_i >= 0, "Invalid parent parameters"
-    assert a_j > 0 and b_j >= 0, "Invalid child parameters"
     assert y_ij >= 0 and mu_ij > 0, "Invalid edge parameters"
 
     a = a_i + a_j + y_ij
     b = a_j
     c = a_j + y_ij + 1
     t = mu_ij + b_i
 
+    assert a > 0 and b > 0 and c > 0, "Invalid local posterior"
+
     log_f, sign_f, da_i, db_i, da_j, db_j = hypergeo._hyp2f1(
         a_i, b_i, a_j, b_j, y_ij, mu_ij
     )

tsdate/hypergeo.py

@@ -353,11 +353,34 @@ def _hyp2f1_dlmf1583(a_i, b_i, a_j, b_j, y, mu):
         a_i, b_i, a_j, b_j, y, mu
     )
 
-    if np.abs(f_1 - f_2) < _HYP2F1_TOL:
-        # TODO: detect a priori if this will occur
-        raise Invalid2F1("Singular hypergeometric function")
-
     f_0 = max(f_1, f_2)
+
+    # 2sum
+    aa = f_1
+    bb = -1 * f_0
+    s = aa + bb
+    ap = s - bb
+    bp = s - ap
+    da = aa - ap
+    db = bb - bp
+    t = da + db
+    print("2sum", s, t)
+
+    aa = f_2
+    bb = -1 * f_0
+    s = aa + bb
+    ap = s - bb
+    bp = s - ap
+    da = aa - ap
+    db = bb - bp
+    t = da + db
+    print("2sum", s, t)
+    # /2sum
+
+    # if np.abs(f_1 - f_2) < _HYP2F1_TOL:
+    #    # TODO: detect a priori if this will occur
+    #    raise Invalid2F1("Singular hypergeometric function")
+
     f_1 = np.exp(f_1 - f_0) * s_1
     f_2 = np.exp(f_2 - f_0) * s_2
     f = f_1 + f_2