notes

Author: molpopgen

examples/manual_metadata_encoding.rs

@@ -60,8 +60,11 @@ impl MetadataRoundtrip for IndividualMetadata {
         let md = &md[size..];
         let md = &md[std::mem::size_of::<usize>()..];
         let mut phenotypes = vec![];
+        // NOTE: production code would want to validate that
+        // the remaining number of bytes are correct
         let chunks = md.chunks_exact(std::mem::size_of::<i32>());
         for c in chunks {
+            // Unwrap b/c the conversion cannot fail b/c the chunk size is correct!
             let a: [u8; std::mem::size_of::<i32>()] = c.try_into().unwrap();
             phenotypes.push(i32::from_le_bytes(a));
         }