curious...

Author: molpopgen

Cargo.toml

@@ -25,7 +25,7 @@ libc = "0.2.155"
 streaming-iterator = "0.1.5"
 serde = {version = "1.0.203", features = ["derive"], optional = true}
 serde_json = {version = "1.0.120", optional = true}
-bincode = {version = "2", optional = true}
+bincode = {version = "2", optional = true, features = ["serde"]}
 tskit-derive = {version = "0.2.0", path = "tskit-derive", optional = true}
 chrono = { version = "0.4.40", default-features = false, features = ["now", "std"] , optional = true}
 
@@ -35,7 +35,7 @@ clap = {version = "4.4.6", features = ["derive"]}
 serde = {version = "1.0.203", features = ["derive"]}
 serde-pickle = "1.1.0"
 serde_json = {version = "1.0.120"}
-bincode = "2"
+bincode = {version = "2", features = ["serde"]}
 rand = "0.8.3"
 rand_distr = "0.4.0"
 

src/test_fixtures.rs

@@ -17,11 +17,17 @@ impl Default for GenericMetadata {
 #[cfg(test)]
 impl crate::metadata::MetadataRoundtrip for GenericMetadata {
     fn encode(&self) -> Result<Vec<u8>, crate::metadata::MetadataError> {
-        handle_metadata_return!(bincode::serialize(&self))
+        handle_metadata_return!(bincode::serde::encode_to_vec(
+            &self,
+            bincode::config::standard()
+        ))
     }
 
     fn decode(md: &[u8]) -> Result<Self, crate::metadata::MetadataError> {
-        handle_metadata_return!(bincode::deserialize(md))
+        handle_metadata_return!(bincode::serde::decode_from_slice(
+            md,
+            bincode::config::standard()
+        ))
     }
 }
 

tskit-derive/src/lib.rs

@@ -30,7 +30,7 @@ fn impl_serde_bincode_roundtrip(name: &syn::Ident) -> TokenStream {
     let gen = quote::quote!(
         impl ::tskit::metadata::MetadataRoundtrip for #name {
             fn encode(&self) -> Result<Vec<u8>, ::tskit::metadata::MetadataError> {
-                match ::bincode::serialize(&self) {
+                match ::bincode::serde::serialize(&self) {
                     Ok(x) => Ok(x),
                     Err(e) => {
                         Err(::tskit::metadata::MetadataError::RoundtripError { value: Box::new(e) })