cool

Author: molpopgen

src/table_collection.rs

@@ -1756,10 +1756,14 @@ impl TableCollection {
         }
 
         // convert sys version of tables to non-sys version of tables
-        let new_edges = EdgeTable::new_from_table(new_edges.as_mut())?;
-        let new_migrations = MigrationTable::new_from_table(new_migrations.as_mut())?;
-        let new_mutations = MutationTable::new_from_table(new_mutations.as_mut())?;
-        let new_sites = SiteTable::new_from_table(new_sites.as_mut())?;
+        // SAFETY: all the casts to *mut Foo are coming in via an implicit
+        // cast from &mut Foo, which means that the ptr cannot be NULL.
+        // Further, all input tables are initialized.
+        // Finally, none of these variables will be every be pub.
+        let new_edges = unsafe { EdgeTable::new_from_table(new_edges.as_mut())? };
+        let new_migrations = unsafe { MigrationTable::new_from_table(new_migrations.as_mut())? };
+        let new_mutations = unsafe { MutationTable::new_from_table(new_mutations.as_mut())? };
+        let new_sites = unsafe { SiteTable::new_from_table(new_sites.as_mut())? };
 
         // replace old tables with new tables
         tables.set_edges(&new_edges).map(|_| ())?;