Skip to content

Commit a1bb8c4

Browse files
committed
tests compile
1 parent 46c7ef3 commit a1bb8c4

File tree

2 files changed

+24
-35
lines changed

2 files changed

+24
-35
lines changed

src/edge_differences.rs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -122,16 +122,16 @@ pub struct X<'ts, T: EdgeDifferenceIteration> {
122122
edges_right: &'ts [Position],
123123
edges_parent: &'ts [NodeId],
124124
edges_child: &'ts [NodeId],
125-
removals: (usize, usize),
125+
range: (usize, usize),
126126
marker: std::marker::PhantomData<T>,
127127
}
128128

129129
impl<'ts, T: EdgeDifferenceIteration> Iterator for X<'ts, T> {
130130
type Item = EdgeDifference<T>;
131131
fn next(&mut self) -> Option<Self::Item> {
132-
if self.removals.0 < self.removals.1 {
133-
let index = self.removals.0;
134-
self.removals.0 += 1;
132+
if self.range.0 < self.range.1 {
133+
let index = self.range.0;
134+
self.range.0 += 1;
135135
Some(Self::Item::new(
136136
self.edges_left[index],
137137
self.edges_right[index],
@@ -151,7 +151,7 @@ impl<'ts> EdgeDifferences<'ts> {
151151
edges_right: self.edges_right,
152152
edges_parent: self.edges_parent,
153153
edges_child: self.edges_child,
154-
removals: self.removals,
154+
range: self.removals,
155155
marker: std::marker::PhantomData::<Removal> {},
156156
}
157157
}
@@ -162,7 +162,7 @@ impl<'ts> EdgeDifferences<'ts> {
162162
edges_right: self.edges_right,
163163
edges_parent: self.edges_parent,
164164
edges_child: self.edges_child,
165-
removals: self.insertions,
165+
range: self.insertions,
166166
marker: std::marker::PhantomData::<Insertion> {},
167167
}
168168
}

tests/book_trees.rs

Lines changed: 18 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -168,17 +168,13 @@ fn initialize_from_table_collection() {
168168
// }
169169

170170
// ANCHOR: iterate_edge_differences
171-
if let Ok(mut edge_diff_iterator) = treeseq.edge_differences_iter() {
172-
while let Some(diffs) = edge_diff_iterator.next() {
173-
for edge_removal in diffs.edge_removals() {
174-
println!("{}", edge_removal);
175-
}
176-
for edge_insertion in diffs.edge_insertions() {
177-
println!("{}", edge_insertion);
178-
}
171+
for diffs in treeseq.edge_differences_iter() {
172+
for edge_removal in diffs.removals() {
173+
println!("{}", edge_removal);
174+
}
175+
for edge_insertion in diffs.insertions() {
176+
println!("{}", edge_insertion);
179177
}
180-
} else {
181-
panic!("creating edge diffs iterator failed");
182178
}
183179
// ANCHOR_END: iterate_edge_differences
184180

@@ -187,25 +183,18 @@ fn initialize_from_table_collection() {
187183
// num_nodes + 1 to reflect a "virtual root" present in
188184
// the tree arrays
189185
let mut parents = vec![NodeId::NULL; num_nodes + 1];
190-
match treeseq.edge_differences_iter() {
191-
Ok(mut ediff_iter) => match treeseq.tree_iterator(0) {
192-
Ok(mut tree_iter) => {
193-
while let Some(diffs) = ediff_iter.next() {
194-
let tree = tree_iter.next().unwrap();
195-
for edge_out in diffs.edge_removals() {
196-
let c = edge_out.child();
197-
parents[c.as_usize()] = NodeId::NULL;
198-
}
199-
for edge_in in diffs.edge_insertions() {
200-
let c = edge_in.child();
201-
parents[c.as_usize()] = edge_in.parent();
202-
}
203-
assert_eq!(tree.parent_array(), &parents);
204-
}
205-
}
206-
Err(e) => panic!("error creating tree iter: {:?}", e),
207-
},
208-
Err(e) => panic!("error creating edge diff iter: {:?}", e),
186+
let mut tree_iter = treeseq.tree_iterator(0).unwrap();
187+
for diffs in treeseq.edge_differences_iter() {
188+
let tree = tree_iter.next().unwrap();
189+
for edge_out in diffs.removals() {
190+
let c = edge_out.child();
191+
parents[c.as_usize()] = NodeId::NULL;
192+
}
193+
for edge_in in diffs.insertions() {
194+
let c = edge_in.child();
195+
parents[c.as_usize()] = edge_in.parent();
196+
}
197+
assert_eq!(tree.parent_array(), &parents);
209198
}
210199
// ANCHOR_END: iterate_edge_differences_update_parents
211200
}

0 commit comments

Comments
 (0)