better

Author: molpopgen

src/sys/flags.rs

@@ -688,7 +688,7 @@ impl NodeFlags {
     ///
     /// This function is called `mark_sample` to not conflict
     /// with [`NodeFlags::is_sample`], which predates it.
-    fn mark_sample(self) -> Self {
+    pub fn mark_sample(self) -> Self {
         Self(self.0 | Self::IS_SAMPLE)
     }
 
@@ -710,15 +710,15 @@ impl NodeFlags {
     }
 
     pub fn contains(&self, bit: tsk_flags_t) -> bool {
-        (self.0 & bit) != 0
+        bit == 0 || (self.0 & bit) != 0
     }
 
-    pub fn toggle(self, bit: tsk_flags_t) -> Self {
-        Self(self.0 ^ bit)
+    pub fn toggle(&mut self, bit: tsk_flags_t) {
+        self.0 ^= bit
     }
 
-    pub fn remove(self, bit: tsk_flags_t) -> Self {
-        Self(self.0 & !bit)
+    pub fn remove(&mut self, bit: tsk_flags_t) {
+        self.0 &= !bit
     }
 }