Skip to content

Commit f2f8987

Browse files
benjefferymergify-bot
authored andcommitted
Fix nbytes tests
1 parent 7a20263 commit f2f8987

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

python/tests/test_tables.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -94,8 +94,8 @@ def make_input_data(self, num_rows):
9494
for list_col, offset_col in self.ragged_list_columns:
9595
lengths = rng.randint(low=0, high=10, size=num_rows)
9696
input_data[list_col.name] = list_col.get_input(sum(lengths))
97-
input_data[offset_col.name] = np.zeros(num_rows + 1, dtype=np.uint32)
98-
input_data[offset_col.name][1:] = np.cumsum(lengths, dtype=np.uint32)
97+
input_data[offset_col.name] = np.zeros(num_rows + 1, dtype=np.uint64)
98+
input_data[offset_col.name][1:] = np.cumsum(lengths, dtype=np.uint64)
9999
return input_data
100100

101101
def make_transposed_input_data(self, num_rows):
@@ -738,7 +738,6 @@ def test_equality(self):
738738
assert t1 is not None
739739
assert t1 != []
740740

741-
@pytest.mark.skip("FIXME nbytes")
742741
def test_nbytes(self):
743742
for num_rows in [0, 10, 100]:
744743
input_data = self.make_input_data(num_rows)
@@ -3165,7 +3164,6 @@ def test_str(self):
31653164
s = str(tables)
31663165
assert len(s) > 0
31673166

3168-
@pytest.mark.skip("FIXME nbytes")
31693167
def test_nbytes(self, tmp_path, ts_fixture):
31703168
tables = ts_fixture.dump_tables()
31713169
tables.dump(tmp_path / "tables")
@@ -3174,7 +3172,7 @@ def test_nbytes(self, tmp_path, ts_fixture):
31743172
# Check we really have data in every field
31753173
assert v.nbytes > 0
31763174
nbytes = sum(
3177-
array.nbytes
3175+
array.nbytes * 2 if "_offset" in name else array.nbytes
31783176
for name, array in store.items()
31793177
# nbytes is the size of asdict, so exclude file format items
31803178
if name not in ["format/version", "format/name", "uuid"]

0 commit comments

Comments
 (0)