Skip to content

Commit b0c6572

Browse files
authored
fix(amazonq): bundle corect registry.node for windows (aws#2061)
1 parent 0955154 commit b0c6572

File tree

3 files changed

+13
-1
lines changed

3 files changed

+13
-1
lines changed

app/aws-lsp-codewhisperer-runtimes/README.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,17 @@ The server is managed via scripts/dev-server.js, which ensures:
7676

7777
**NOTE**: Tests are currently disabled for Windows as we currently face issues with automatically shutting down devserver and cleaning resources after tests are executed.
7878

79+
## Binary Dependencies
80+
81+
### registry.node
82+
The file `_bundle-assets/registry-js/win32-x64/registry.node` is a precompiled binary downloaded from the [registry-js](https://github.com/desktop/registry-js) project.
83+
84+
- **Current version**: v1.16.1 (released May 21, 2024)
85+
- **Source**: https://github.com/desktop/registry-js/releases
86+
- **Purpose**: Provides Windows registry access functionality
87+
88+
**To update**: Download the latest `registry.node` binary for win32-x64 from the registry-js releases page and replace the existing file.
89+
7990
#### Tests configuration
8091
- Test settings are defined in `wdio.conf.ts`
8192
- The actual test implementation is in the `test/e2e` folder
Binary file not shown.

app/aws-lsp-codewhisperer-runtimes/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,11 @@
1010
"package:prod": "npm run compile && cross-env NODE_OPTIONS=--max_old_space_size=8172 npm run webpack:prod",
1111
"webpack": "webpack",
1212
"webpack:prod": "webpack --config webpack.config.prod.js",
13+
"copy:native-deps:agent-standalone": "copyfiles -f _bundle-assets/registry-js/win32-x64/registry.node build/private/bundle/agent-standalone",
1314
"copy:resources:agent-standalone": "copyfiles -f --error ../../node_modules/@aws/lsp-identity/src/sso/authorizationCodePkce/resources/**/* build/private/bundle/agent-standalone/resources",
1415
"generate:node-assets": "./scripts/download-node.sh && ts-node src/scripts/copy-node-assets.ts",
1516
"generate:build-archive": "./scripts/package.sh",
16-
"ci:generate:agent-standalone": "npm run package:prod && npm run copy:resources:agent-standalone && npm run generate:node-assets && npm run generate:build-archive",
17+
"ci:generate:agent-standalone": "npm run package:prod && npm run copy:native-deps:agent-standalone && npm run copy:resources:agent-standalone && npm run generate:node-assets && npm run generate:build-archive",
1718
"ci:generate:manifest": "ts-node scripts/create-repo-manifest.ts",
1819
"start": "cross-env NODE_OPTIONS=--max_old_space_size=8172 node scripts/dev-server.js start",
1920
"stop-dev-server": "node scripts/dev-server.js stop",

0 commit comments

Comments
 (0)