Skip to content

Commit 45e90aa

Browse files
committed
Fix PR comments
1 parent 4b88b50 commit 45e90aa

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

src/Bot/Dubtrack.hs

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -69,16 +69,16 @@ songLink (songType -> SongTypeSoundcloud) =
6969
"Soundcloud links are not supported yet"
7070
songLink _ = error "This should never happen Kappa"
7171

72-
newtype RoomName = RoomName
72+
newtype DubtrackRoom = DubtrackRoom
7373
{ unName :: T.Text
7474
}
7575

76-
instance IsEntity RoomName where
76+
instance IsEntity DubtrackRoom where
7777
nameOfEntity _ = "DubtrackRoom"
7878
toProperties reply = Map.fromList [("name", PropertyText $ unName reply)]
79-
fromProperties = fmap RoomName . extractProperty "name"
79+
fromProperties = fmap DubtrackRoom . extractProperty "name"
8080

81-
getRoom :: Effect (Maybe (Entity RoomName))
81+
getRoom :: Effect (Maybe (Entity DubtrackRoom))
8282
getRoom = listToMaybe <$> selectEntities P.Proxy (Take 1 All)
8383

8484
setDubtrackRoom :: Reaction Message T.Text
@@ -89,10 +89,11 @@ setDubtrackRoom =
8989
case mayReply of
9090
Just reply ->
9191
void $ updateEntityById $ (\a -> a {unName = msg}) <$> reply
92-
Nothing -> void $ createEntity P.Proxy $ RoomName msg) $
92+
Nothing -> void $ createEntity P.Proxy $ DubtrackRoom msg) $
9393
cmapR (const "Updated room for dubtrack") $ Reaction replyMessage
9494

9595
-- TODO(#221): Dubtrack room is hardcode
96+
-- TODO: Rewrite in the Reaction api
9697
currentSongCommand :: Reaction Message ()
9798
currentSongCommand =
9899
Reaction $ \Message {messageSender = sender} -> do
@@ -101,7 +102,7 @@ currentSongCommand =
101102
Nothing ->
102103
replyToSender
103104
sender
104-
"Dubtrack room not set, a mod can run '!config dubtrack $ROOM_NAME' to set it"
105+
"Dubtrack room not set, a mod can run '!config dubtrack <room-name>' to set it"
105106
Just mahroom -> do
106107
request <-
107108
parseRequest $

0 commit comments

Comments
 (0)