Skip to content

Commit d75bcbd

Browse files
committed
Remove finished TODOs
1 parent a94db20 commit d75bcbd

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

coroutine.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -256,8 +256,6 @@ void coroutine_go(void (*f)(void*), void *arg)
256256
if (dead.count > 0) {
257257
id = dead.items[--dead.count];
258258
} else {
259-
// TODO: Mark the page at the end of the stack buffer as non-readable, non-writable, non-executable to make stack overflows of coroutines more obvious in the debugger
260-
// This may require employing mmap(2) and mprotect(2) on Linux.
261259
da_append(&contexts, ((Context){0}));
262260
id = contexts.count-1;
263261
contexts.items[id].stack_base = mmap(NULL, STACK_CAPACITY, PROT_WRITE|PROT_READ, MAP_PRIVATE|MAP_STACK|MAP_ANONYMOUS|MAP_GROWSDOWN, -1, 0);

0 commit comments

Comments
 (0)