Skip to content

Commit 58b8c25

Browse files
matteobrunimatteobruni
committed
build: updating eslint rules and deps
1 parent 877d579 commit 58b8c25

File tree

9 files changed

+651
-571
lines changed

9 files changed

+651
-571
lines changed

‎lerna.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"$schema": "node_modules/lerna/schemas/lerna-schema.json",
3-
"version": "independent",
3+
"version": "2.0.0",
44
"npmClient": "pnpm",
55
"conventionalCommits": true,
66
"packages": ["packages/*"],

‎packages/eslint-config/eslint-config.js‎

Lines changed: 104 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -2,23 +2,32 @@ module.exports = {
22
root: true,
33
parser: "@typescript-eslint/parser",
44
parserOptions: {
5-
project: "./tsconfig.json"
5+
project: "./tsconfig.json",
66
},
7-
plugins: ["@typescript-eslint", "jsdoc", "eslint-plugin-tsdoc"],
8-
extends: ["eslint:recommended", "plugin:@typescript-eslint/eslint-recommended", "plugin:@typescript-eslint/recommended", "plugin:jsdoc/recommended-typescript", "prettier"],
7+
plugins: [ "@typescript-eslint", "jsdoc", "eslint-plugin-tsdoc" ],
8+
extends: [
9+
"eslint:recommended",
10+
"plugin:@typescript-eslint/eslint-recommended",
11+
"plugin:@typescript-eslint/recommended",
12+
"plugin:@typescript-eslint/stylistic",
13+
"plugin:@typescript-eslint/recommended-type-checked",
14+
"plugin:@typescript-eslint/stylistic-type-checked",
15+
"plugin:jsdoc/recommended-typescript",
16+
"prettier"
17+
],
918
rules: {
1019
"@typescript-eslint/ban-types": "warn",
11-
"@typescript-eslint/comma-spacing": ["error"],
12-
"@typescript-eslint/consistent-generic-constructors": ["error", "constructor"],
13-
"@typescript-eslint/consistent-type-exports": ["error"],
14-
"@typescript-eslint/consistent-type-imports": ["error"],
20+
"@typescript-eslint/comma-spacing": [ "error" ],
21+
"@typescript-eslint/consistent-generic-constructors": [ "error", "constructor" ],
22+
"@typescript-eslint/consistent-type-exports": [ "error" ],
23+
"@typescript-eslint/consistent-type-imports": [ "error" ],
1524
"@typescript-eslint/explicit-function-return-type": "error",
16-
"@typescript-eslint/explicit-member-accessibility": ["error", {
25+
"@typescript-eslint/explicit-member-accessibility": [ "error", {
1726
accessibility: "no-public"
18-
}],
27+
} ],
1928
"@typescript-eslint/no-explicit-any": "error", //"@typescript-eslint/no-extra-parens": [ "error" ],
2029
"@typescript-eslint/no-inferrable-types": "error",
21-
"@typescript-eslint/member-ordering": ["error", {
30+
"@typescript-eslint/member-ordering": [ "error", {
2231
default: {
2332
memberTypes: [// Index signature
2433
"signature",
@@ -46,21 +55,21 @@ module.exports = {
4655
"constructor",
4756

4857
// Getters & Setters
49-
["public-static-get", "public-static-set"], ["protected-static-get", "protected-static-set"], ["private-static-get", "private-static-set"],
58+
[ "public-static-get", "public-static-set" ], [ "protected-static-get", "protected-static-set" ], [ "private-static-get", "private-static-set" ],
5059

51-
["public-decorated-get", "public-decorated-set"], ["protected-decorated-get", "protected-decorated-set"], ["private-decorated-get", "private-decorated-set"],
60+
[ "public-decorated-get", "public-decorated-set" ], [ "protected-decorated-get", "protected-decorated-set" ], [ "private-decorated-get", "private-decorated-set" ],
5261

53-
["public-instance-get", "public-instance-set"], ["protected-instance-get", "protected-instance-set"], ["private-instance-get", "private-instance-set"],
62+
[ "public-instance-get", "public-instance-set" ], [ "protected-instance-get", "protected-instance-set" ], [ "private-instance-get", "private-instance-set" ],
5463

55-
["public-abstract-get", "public-abstract-set"], ["protected-abstract-get", "protected-abstract-set"],
64+
[ "public-abstract-get", "public-abstract-set" ], [ "protected-abstract-get", "protected-abstract-set" ],
5665

57-
["public-get", "public-set"], ["protected-get", "protected-set"], ["private-get", "private-set"],
66+
[ "public-get", "public-set" ], [ "protected-get", "protected-set" ], [ "private-get", "private-set" ],
5867

59-
["static-get", "static-set"], ["instance-get", "instance-set"], ["abstract-get", "abstract-set"],
68+
[ "static-get", "static-set" ], [ "instance-get", "instance-set" ], [ "abstract-get", "abstract-set" ],
6069

61-
["decorated-get", "decorated-set"],
70+
[ "decorated-get", "decorated-set" ],
6271

63-
["get", "set"],
72+
[ "get", "set" ],
6473

6574
// Methods
6675
"public-static-method", "protected-static-method", "private-static-method",
@@ -77,29 +86,95 @@ module.exports = {
7786

7887
"decorated-method",
7988

80-
"method"], order: "alphabetically"
89+
"method" ], order: "alphabetically"
8190
}
82-
}],
91+
} ],
8392
"@typescript-eslint/no-unnecessary-type-arguments": "error",
8493
"@typescript-eslint/no-unnecessary-type-assertion": "error",
85-
"@typescript-eslint/no-unused-vars": ["error", {
94+
"@typescript-eslint/no-unused-vars": [ "error", {
8695
argsIgnorePattern: "^_",
8796
caughtErrorsIgnorePattern: "^_",
8897
destructuredArrayIgnorePattern: "^_",
8998
varsIgnorePattern: "^_"
90-
}],
99+
} ],
91100
"@typescript-eslint/no-var-requires": "error",
92-
"@typescript-eslint/prefer-readonly": ["error"],
93-
"comma-spacing": "off", //"no-extra-parens": "off",
101+
"@typescript-eslint/prefer-readonly": [ "error" ],
102+
"comma-spacing": "off",
94103
"no-console": "error",
95-
"sort-imports": ["error", {
104+
"sort-imports": [ "error", {
96105
allowSeparatedGroups: false,
97106
ignoreCase: false,
98107
ignoreDeclarationSort: false,
99108
ignoreMemberSort: false,
100-
memberSyntaxSortOrder: ["none", "all", "multiple", "single"]
101-
}],
102-
"tsdoc/syntax": "warn"
103-
109+
memberSyntaxSortOrder: [ "none", "all", "multiple", "single" ]
110+
} ],
111+
"tsdoc/syntax": "warn",
112+
"no-nested-ternary": "error",
113+
"no-unneeded-ternary": "error",
114+
"no-var": "error",
115+
"prefer-const": "error",
116+
"prefer-object-spread": "error",
117+
"prefer-template": "error",
118+
"quote-props": [ "error", "as-needed" ],
119+
"quotes": [ "error", "double", {
120+
allowTemplateLiterals: true,
121+
avoidEscape: true
122+
} ],
123+
"semi": [ "error", "always" ],
124+
"space-before-blocks": "error",
125+
"space-in-parens": [ "error", "never" ],
126+
"space-infix-ops": "error",
127+
"spaced-comment": [ "error", "always", {
128+
block: {
129+
balanced: true
130+
}
131+
} ],
132+
"yoda": [ "error", "never", {
133+
exceptRange: true
134+
} ],
135+
"keyword-spacing": "error",
136+
"arrow-spacing": "error",
137+
"no-duplicate-imports": "error",
138+
"no-useless-constructor": "error",
139+
"no-useless-rename": "error",
140+
"no-useless-return": "error",
141+
"no-useless-computed-key": "error",
142+
"no-useless-concat": "error",
143+
"no-useless-escape": "error",
144+
"constructor-super": "error",
145+
"no-this-before-super": "error",
146+
"no-duplicate-case": "error",
147+
"no-empty": "error",
148+
"no-extra-semi": "error",
149+
"no-func-assign": "error",
150+
"no-irregular-whitespace": "error",
151+
"no-unexpected-multiline": "error",
152+
"no-unreachable": "error",
153+
"valid-typeof": "error",
154+
"no-unsafe-finally": "error",
155+
"no-case-declarations": "error",
156+
"no-empty-function": "error",
157+
"no-empty-pattern": "error",
158+
"no-extra-boolean-cast": "error",
159+
"no-inner-declarations": "error",
160+
"no-prototype-builtins": "error",
161+
"no-self-assign": "error",
162+
"no-throw-literal": "error",
163+
"no-unused-expressions": "error",
164+
"no-unused-labels": "error",
165+
"no-useless-catch": "error",
166+
"@typescript-eslint/quotes": [ "error", "double", {
167+
allowTemplateLiterals: true,
168+
avoidEscape: true
169+
} ],
170+
"@typescript-eslint/semi": [ "error", "always" ],
171+
"@typescript-eslint/space-before-blocks": "error",
172+
"@typescript-eslint/space-infix-ops": "error",
173+
"@typescript-eslint/keyword-spacing": "error",
174+
"@typescript-eslint/no-useless-constructor": "error",
175+
"@typescript-eslint/no-extra-semi": "error",
176+
"@typescript-eslint/no-empty-function": "error",
177+
"@typescript-eslint/no-throw-literal": "error",
178+
"@typescript-eslint/no-unused-expressions": "error",
104179
}
105180
};

‎packages/eslint-config/package.json‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,14 @@
1212
},
1313
"dependencies": {
1414
"@tsparticles/prettier-config": "^2.0.0",
15-
"@typescript-eslint/eslint-plugin": "^6.12.0",
16-
"@typescript-eslint/parser": "^6.12.0",
17-
"eslint": "^8.54.0",
18-
"eslint-config-prettier": "^9.0.0",
15+
"@typescript-eslint/eslint-plugin": "^6.14.0",
16+
"@typescript-eslint/parser": "^6.14.0",
17+
"eslint": "^8.55.0",
18+
"eslint-config-prettier": "^9.1.0",
1919
"eslint-plugin-import": "^2.29.0",
2020
"eslint-plugin-jsdoc": "^46.9.0",
2121
"eslint-plugin-tsdoc": "^0.2.17",
22-
"prettier": "^3.1.0",
23-
"typescript": "^5.3.2"
22+
"prettier": "^3.1.1",
23+
"typescript": "^5.3.3"
2424
}
2525
}

‎packages/prettier-config/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
"access": "public"
1313
},
1414
"dependencies": {
15-
"prettier": "^3.1.0",
15+
"prettier": "^3.1.1",
1616
"prettier-plugin-multiline-arrays": "^3.0.1"
1717
}
1818
}

‎packages/tsconfig/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,6 @@
77
"access": "public"
88
},
99
"dependencies": {
10-
"typescript": "^5.3.2"
10+
"typescript": "^5.3.3"
1111
}
1212
}

‎packages/webpack-config/package.json‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -25,28 +25,28 @@
2525
},
2626
"prettier": "@tsparticles/prettier-config",
2727
"dependencies": {
28-
"@babel/core": "^7.23.3",
29-
"@babel/preset-env": "^7.23.3",
28+
"@babel/core": "^7.23.6",
29+
"@babel/preset-env": "^7.23.6",
3030
"@tsparticles/eslint-config": "^2.0.0",
3131
"@tsparticles/prettier-config": "^2.0.0",
3232
"@types/node": "^20.10.0",
3333
"@types/webpack-bundle-analyzer": "^4.6.3",
3434
"@types/webpack-env": "^1.18.4",
35-
"@typescript-eslint/eslint-plugin": "^6.12.0",
36-
"@typescript-eslint/parser": "^6.12.0",
35+
"@typescript-eslint/eslint-plugin": "^6.14.0",
36+
"@typescript-eslint/parser": "^6.14.0",
3737
"babel-loader": "^9.1.3",
38-
"browserslist": "^4.22.1",
38+
"browserslist": "^4.22.2",
3939
"copyfiles": "^2.4.1",
40-
"eslint": "^8.54.0",
41-
"eslint-config-prettier": "^9.0.0",
40+
"eslint": "^8.55.0",
41+
"eslint-config-prettier": "^9.1.0",
4242
"eslint-plugin-import": "^2.29.0",
4343
"eslint-plugin-jsdoc": "^46.9.0",
4444
"eslint-plugin-tsdoc": "^0.2.17",
45-
"prettier": "^3.1.0",
45+
"prettier": "^3.1.1",
4646
"prettier-plugin-multiline-arrays": "^3.0.1",
4747
"rimraf": "^5.0.5",
4848
"terser-webpack-plugin": "^5.3.9",
49-
"typescript": "^5.3.2",
49+
"typescript": "^5.3.3",
5050
"webpack": "^5.89.0",
5151
"webpack-bundle-analyzer": "^4.10.1",
5252
"webpack-cli": "^5.1.4"

‎packages/webpack-config/src/bundles/getBundleEntry.ts‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
import { getEntry } from "../common/getEntry";
22

3-
const getBundleEntry = (name: string, bundle: boolean): unknown => {
4-
const fixName = name && name.startsWith(".") ? name.substring(1) : name ? name : "";
3+
const getFixedName = (name: string): string => (name && name.startsWith(".") ? name.substring(1) : name || "");
54

6-
return getEntry("", fixName, bundle);
7-
};
5+
const getBundleEntry = (name: string, bundle: boolean): unknown => getEntry("", getFixedName(name), bundle);
86

97
export { getBundleEntry };

‎packages/webpack-config/src/common/getExternals.ts‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,11 @@ const getExternals = (params: ExternalsParams): unknown[] => {
3131
return [
3232
...externals.map(transformExternal),
3333
function ({ request }: { request: string }, cb: (err?: Error | null, data?: unknown) => void): void {
34-
if ("tsparticles" === request || /^tsparticles-/.test(request) || /^@tsparticles\//.test(request)) {
34+
if (
35+
request === "tsparticles" ||
36+
request.startsWith("tsparticles-") ||
37+
request.startsWith("@tsparticles/")
38+
) {
3539
cb(null, getExternalObject(request));
3640

3741
return;

0 commit comments

Comments
 (0)