do not startup if files are not found

Author: tstack

CMakeLists.txt

@@ -5,7 +5,7 @@ include(cmake/prelude.cmake)
 set(CMAKE_CXX_STANDARD 17)
 project(
         lnav
-        VERSION 0.13.1
+        VERSION 0.13.2
         DESCRIPTION "An advanced log file viewer for the terminal."
         HOMEPAGE_URL "https://lnav.org/"
         LANGUAGES CXX C

NEWS.md

@@ -1,8 +1,12 @@
 
-## lnav v0.13.1a
+## lnav v0.13.2
 
 Bug Fixes:
 * Kitty keyboard handling was broken at the last minute.
+* The TUI no longer opens if a bad file name is passed.
+* The abbreviated month `%b` time-conversion was not
+  always falling back to English locale, which could
+  prevent lnav from starting up.
 
 ## lnav v0.13.1
 

configure.ac

@@ -1,4 +1,4 @@
-AC_INIT([lnav],[0.13.1a],[lnav@googlegroups.com],[lnav],[http://lnav.org])
+AC_INIT([lnav],[0.13.2],[lnav@googlegroups.com],[lnav],[http://lnav.org])
 AC_CONFIG_SRCDIR([src/lnav.cc])
 AC_CONFIG_MACRO_DIR([m4])
 AM_INIT_AUTOMAKE([foreign subdir-objects])

release/Makefile

@@ -1,5 +1,5 @@
 
-VERSION=0.13.1a
+VERSION=0.13.2
 
 VERSION_TAG=v$(VERSION)
 

src/base/fs_util.cc

@@ -206,14 +206,14 @@ determine_path_type(const std::string& arg)
         return path_type::url;
     }
 
-    switch (arg.find(':')) {
-        case 0:
-            return path_type::normal;
-        case 1:
-            return path_type::windows;
-        default:
-            return path_type::remote;
+    const auto colon_pos = arg.find(':');
+    if (colon_pos == std::string::npos) {
+        return path_type::normal;
+    }
+    if (colon_pos == 1) {
+        return path_type::windows;
     }
+    return path_type::remote;
 }
 
 path_transcoder

test/expected/Makefile.am

@@ -4,6 +4,8 @@ dist_noinst_DATA = \
     test_cli.sh_0b3639753916f71254e8c9cce4ebb8bfd9978d3e.out \
     test_cli.sh_10c33e465ef7681c6b5519d05d557426b26cd43d.err \
     test_cli.sh_10c33e465ef7681c6b5519d05d557426b26cd43d.out \
+    test_cli.sh_1507a515f62dfc9ad0af85decadbd7921be9b96d.err \
+    test_cli.sh_1507a515f62dfc9ad0af85decadbd7921be9b96d.out \
     test_cli.sh_17a68b798354f9a6cdfab372006caeb74038d15c.err \
     test_cli.sh_17a68b798354f9a6cdfab372006caeb74038d15c.out \
     test_cli.sh_1ec76eb2416d2c09c13eba62ff8bcf920a888b9c.err \

test/expected/test_cli.sh_1507a515f62dfc9ad0af85decadbd7921be9b96d.err

@@ -0,0 +1,5 @@
+✘ error: unable to open file: badfilename
+ reason: No such file or directory
+✘ error: unable to display interactive text UI
+ reason: stdout is not a TTY
+ = help: pass the -n option to run lnav in headless mode or don't redirect stdout

test/expected/test_cli.sh_1507a515f62dfc9ad0af85decadbd7921be9b96d.out

@@ -1,5 +1,5 @@
 
-lnav 0.13.1a
+lnav 0.13.2
 
 A fancy log file viewer for the terminal.
 

test/expected/test_cmds.sh_b6a3bb78e9d60e5e1f5ce5b18e40d2f1662707ab.out

@@ -3,8 +3,8 @@
 # '|/path/to/this/file' in lnav to execute this file and
 # restore the state of the session.
 
-;SELECT raise_error('This session export was made with a newer version of lnav, please upgrade to ' || '0.13.1a' || ' or later')
-   WHERE lnav_version() < '0.13.1a' COLLATE naturalcase
+;SELECT raise_error('This session export was made with a newer version of lnav, please upgrade to ' || '0.13.2' || ' or later')
+   WHERE lnav_version() < '0.13.2' COLLATE naturalcase
 
 # The files loaded into the session were: