Round trip the PostgresSQL Removal. (#196)

* Round Trip Round 2

* Add git hook support.

Author: csev

README_COMPOSER.md

@@ -1,23 +1,27 @@
 
 To update only one thing whilst not bumping the transitive dependencies
 
-    composer update tsugi/lib
-    composer update symfony/browser-kit
+    composer update tsugi/lib --no-dev
+    composer update symfony/browser-kit --no-dev
 
 And to ignore platform requirements:
 
-    composer update tsugi/lib --ignore-platform-reqs
+    composer update tsugi/lib --ignore-platform-reqs --no-dev
 
 To advance dependencies
 
-    composer update --ignore-platform-reqs
+    composer update --ignore-platform-reqs --no-dev
 
 Make sure to allow it to work with any version of PHP
 
 When advancing the version of PHP and moving from the php-84-x branch to master, update
 composer.json to master-dev hashes and type:
 
-composer update tsugi/lib koseu/lib --ignore-platform-reqs
+    composer update tsugi/lib koseu/lib --ignore-platform-reqs --no-dev
 
 This way to does not trigger a fresh dependency advance across the board.
 
+Run this before pushing for sanity check:
+
+    bash qa/pre-commit-vendor-check.sh 
+

composer.json

@@ -36,7 +36,7 @@
         "react/dns" : ">=1.13.0",
         "react/socket" : ">=1.16.0",
 
-        "tsugi/lib": "dev-master#98f76a64ee0ea00287bebfffc35757fd29c583ca",
+        "tsugi/lib": "dev-master#49b2107797f2936631739ccef847405b3d26a27a",
         "koseu/lib": "dev-master#c5a8e2bd56a33e1a65731a13ed4f350769c9ab3b"
     },
     "config": {

composer.lock

@@ -0,0 +1,22 @@
+#!/usr/bin/env bash
+set -e
+
+HOOK_DIR=".git/hooks"
+HOOK="$HOOK_DIR/pre-commit"
+
+echo "🔧 Installing git pre-commit hook"
+
+mkdir -p "$HOOK_DIR"
+
+cat > "$HOOK" <<'EOF'
+#!/usr/bin/env bash
+set -e
+
+echo "🚦 Running pre-commit vendor sanity check..."
+qa/pre-commit-vendor-check.sh
+EOF
+
+chmod +x "$HOOK"
+
+echo "✅ pre-commit hook installed"
+

qa/install-git-hooks.sh

@@ -0,0 +1,61 @@
+#!/usr/bin/env bash
+set -euo pipefail
+
+echo "🔍 Pre-commit vendor sanity check (prod-clean)"
+
+### Must be run from repo root
+if [ ! -f composer.json ] || [ ! -d vendor ]; then
+  echo "❌ Must be run from repo root with vendor present"
+  exit 1
+fi
+
+### 1. Hard fail if dev-only packages appear in autoload metadata
+echo "→ Checking autoload for dev-only packages"
+
+DEV_PATTERNS=(
+  phpunit
+  mockery
+  myclabs/deep-copy
+  fakerphp
+)
+
+for pat in "${DEV_PATTERNS[@]}"; do
+  if grep -R "$pat" vendor/composer/autoload_files.php >/dev/null 2>&1; then
+    echo "❌ Dev package '$pat' referenced in autoload_files.php"
+    echo "   Vendor was built with dev deps enabled"
+    exit 1
+  fi
+done
+
+### 2. Autoload must actually work
+echo "→ Verifying PHP autoload"
+php -r "require 'vendor/autoload.php';" >/dev/null 2>&1 || {
+  echo "❌ PHP autoload failed"
+  exit 1
+}
+
+### 3. Vendor must match composer.lock in *prod* mode
+echo "→ Verifying vendor matches composer.lock (no-dev)"
+composer install \
+  --no-dev \
+  --prefer-dist \
+  --dry-run \
+  --no-interaction \
+  >/dev/null 2>&1 || {
+    echo "❌ vendor/ does NOT match composer.lock for --no-dev"
+    echo "   Rebuild vendor with: composer install --no-dev"
+    exit 1
+}
+
+### 4. Guard against accidental dev files sneaking in
+echo "→ Checking for dev package directories"
+for pat in "${DEV_PATTERNS[@]}"; do
+  if find vendor -type d -name "*$pat*" | grep -q .; then
+    echo "❌ Dev package directory '$pat' present in vendor/"
+    exit 1
+  fi
+done
+
+echo "✅ Vendor sanity check PASSED"
+echo "👍 Safe to git commit -a && git push"
+

qa/pre-commit-vendor-check.sh

@@ -14,7 +14,10 @@
             echo $err;
         }
     }
-    throw new RuntimeException($err);
+    trigger_error(
+        $err,
+        E_USER_ERROR
+    );
 }
 
 require_once __DIR__ . '/composer/autoload_real.php';

vendor/autoload.php

@@ -26,12 +26,6 @@
  */
 class InstalledVersions
 {
-    /**
-     * @var string|null if set (by reflection by Composer), this should be set to the path where this class is being copied to
-     * @internal
-     */
-    private static $selfDir = null;
-
     /**
      * @var mixed[]|null
      * @psalm-var array{root: array{name: string, pretty_version: string, version: string, reference: string|null, type: string, install_path: string, aliases: string[], dev: bool}, versions: array<string, array{pretty_version?: string, version?: string, reference?: string|null, type?: string, install_path?: string, aliases?: string[], dev_requirement: bool, replaced?: string[], provided?: string[]}>}|array{}|null
@@ -328,18 +322,6 @@ public static function reload($data)
         self::$installedIsLocalDir = false;
     }
 
-    /**
-     * @return string
-     */
-    private static function getSelfDir()
-    {
-        if (self::$selfDir === null) {
-            self::$selfDir = strtr(__DIR__, '\\', '/');
-        }
-
-        return self::$selfDir;
-    }
-
     /**
      * @return array[]
      * @psalm-return list<array{root: array{name: string, pretty_version: string, version: string, reference: string|null, type: string, install_path: string, aliases: string[], dev: bool}, versions: array<string, array{pretty_version?: string, version?: string, reference?: string|null, type?: string, install_path?: string, aliases?: string[], dev_requirement: bool, replaced?: string[], provided?: string[]}>}>
@@ -354,7 +336,7 @@ private static function getInstalled()
         $copiedLocalDir = false;
 
         if (self::$canGetVendors) {
-            $selfDir = self::getSelfDir();
+            $selfDir = strtr(__DIR__, '\\', '/');
             foreach (ClassLoader::getRegisteredLoaders() as $vendorDir => $loader) {
                 $vendorDir = strtr($vendorDir, '\\', '/');
                 if (isset(self::$installedByVendor[$vendorDir])) {

vendor/composer/InstalledVersions.php

@@ -22,8 +22,6 @@ public static function getLoader()
             return self::$loader;
         }
 
-        require __DIR__ . '/platform_check.php';
-
         spl_autoload_register(array('ComposerAutoloaderInit687bd735fc487d23f01529fcf7aa762c', 'loadClassLoader'), true, true);
         self::$loader = $loader = new \Composer\Autoload\ClassLoader(\dirname(__DIR__));
         spl_autoload_unregister(array('ComposerAutoloaderInit687bd735fc487d23f01529fcf7aa762c', 'loadClassLoader'));