AppUI: Handle weird MIDI device setting inheritance

julianxhokaxhiu · julianxhokaxhiu · commit fa029a74a823 · 2026-03-03T23:35:07.000+01:00
If for unknown reasons it is not possible to retrieve the current one set, fallback to the first one in the list
diff --git a/AppUI/ViewModels/GameLaunchSettingsViewModel.cs b/AppUI/ViewModels/GameLaunchSettingsViewModel.cs
@@ -609,17 +609,16 @@ private void SetSelectedSoundDeviceFromSettings(LaunchSettings launchSettings)
 
         private void SetSelectedMidiDeviceFromSettings()
         {
-            int MidiDevIDFromReg = GetMidiDeviceInRegistry();
-
-            if (MidiDevIDFromReg < MidiDevices.Count - 1)
+            try
             {
-                SelectedMidiDevice = MidiDevices.ElementAt(0);
+                int MidiDevIDFromReg = GetMidiDeviceInRegistry();
+                SelectedMidiDevice = MidiDevices.ElementAt(MidiDevIDFromReg);
             }
-            else
+            catch
             {
-                SelectedMidiDevice = MidiDevices.ElementAt(MidiDevIDFromReg);
+                // Always default to first element if picking the current set one fails for some reason
+                SelectedMidiDevice = MidiDevices.ElementAt(0);
             }
-
         }
 
         internal bool SaveSettings()

Original file line number	Diff line number	Diff line change
`@@ -609,17 +609,16 @@ private void SetSelectedSoundDeviceFromSettings(LaunchSettings launchSettings)`
`609`	`609`
`610`	`610`	`private void SetSelectedMidiDeviceFromSettings()`
`611`	`611`	`{`
`612`		`- int MidiDevIDFromReg = GetMidiDeviceInRegistry();`
`613`		`-`
`614`		`- if (MidiDevIDFromReg < MidiDevices.Count - 1)`
	`612`	`+ try`
`615`	`613`	`{`
`616`		`- SelectedMidiDevice = MidiDevices.ElementAt(0);`
	`614`	`+ int MidiDevIDFromReg = GetMidiDeviceInRegistry();`
	`615`	`+ SelectedMidiDevice = MidiDevices.ElementAt(MidiDevIDFromReg);`
`617`	`616`	`}`
`618`		`- else`
	`617`	`+ catch`
`619`	`618`	`{`
`620`		`- SelectedMidiDevice = MidiDevices.ElementAt(MidiDevIDFromReg);`
	`619`	`+ // Always default to first element if picking the current set one fails for some reason`
	`620`	`+ SelectedMidiDevice = MidiDevices.ElementAt(0);`
`621`	`621`	`}`
`622`		`-`
`623`	`622`	`}`
`624`	`623`
`625`	`624`	`internal bool SaveSettings()`