Skip to content

Commit 80f1d51

Browse files
committed
code partially refactored
1 parent 5682ba6 commit 80f1d51

34 files changed

+31
-1017
lines changed

src/Main.java

Lines changed: 30 additions & 995 deletions
Large diffs are not rendered by default.

src/SourceTableRectangle.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,8 @@
33
import java.util.List;
44

55
import org.ohdsi.rabbitInAHat.dataModel.Field;
6-
import org.ohdsi.rabbitInAHat.dataModel.ItemToItemMap;
76
import org.ohdsi.rabbitInAHat.dataModel.Table;
8-
import org.ohdsi.whiteRabbit.ObjectExchange;
97

10-
import javafx.beans.value.ChangeListener;
11-
import javafx.beans.value.ObservableValue;
128
import javafx.event.EventHandler;
139
import javafx.scene.input.MouseEvent;
1410
import javafx.scene.layout.Pane;
@@ -195,11 +191,9 @@ public void toggle(List<? extends Expandable> list) {
195191

196192
@Override
197193
public void expand() {
198-
System.out.println("Expanding itself...");
199194
expandingTable = this;
200195
double currY = y + height;
201196
for (Field fd : table.getFields()) {
202-
System.out.println("Processing " + fd.getName());
203197
currY += FIELD_INTERVAL;
204198
FieldRectangle newNode = new FieldRectangle(currY, fd);
205199
fieldRectList.add(newNode);

src/TargetTableRectangle.java

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,7 @@
55
import org.ohdsi.rabbitInAHat.dataModel.Field;
66
import org.ohdsi.rabbitInAHat.dataModel.Table;
77
import org.ohdsi.whiteRabbit.ObjectExchange;
8-
import javafx.beans.value.ChangeListener;
9-
import javafx.beans.value.ObservableValue;
8+
109
import javafx.event.EventHandler;
1110
import javafx.scene.input.MouseEvent;
1211
import javafx.scene.layout.Pane;
@@ -89,11 +88,8 @@ public void handle(MouseEvent arg0) {
8988
ObjectExchange.etl.getTableToTableMapping().addSourceToTargetMap(SourceTableRectangle.selectingField.field.getTable(), TargetTableRectangle.selectingField.field.getTable());
9089
}
9190
ObjectExchange.etl.getFieldToFieldMapping(SourceTableRectangle.selectingField.field.getTable(), TargetTableRectangle.selectingField.field.getTable()).addSourceToTargetMap(SourceTableRectangle.selectingField.field, TargetTableRectangle.selectingField.field);
92-
System.out.println("Clicked");
9391
TargetTableRectangle.selectingField.field.setDisplayName(TargetTableRectangle.selectingField.field.getName() + " <" + SourceTableRectangle.selectingField.field.getTable().getName() + "." + SourceTableRectangle.selectingField.field.getName() + ">");
9492

95-
System.out.println("Starting point: (" + SourceTableRectangle.selectingField.getBoundsInParent().getMaxX() + "," + (SourceTableRectangle.selectingField.getBoundsInParent().getMinY() + 0.5 * SourceTableRectangle.selectingField.getHeight()) + ")");
96-
System.out.println("Ending point: (" + TargetTableRectangle.selectingField.getBoundsInParent().getMinX() + "," + (TargetTableRectangle.selectingField.getBoundsInParent().getMinY() + 0.5 * TargetTableRectangle.selectingField.getHeight()) + ")");
9793
if (Arrow.displayPane == null) {
9894
Arrow.displayPane = displayPane;
9995
}
@@ -212,11 +208,9 @@ public void toggle(List<? extends Expandable> list) {
212208

213209
@Override
214210
public void expand() {
215-
System.out.println("Expanding itself...");
216211
expandingTable = this;
217212
double currY = y + height;
218213
for (Field fd : table.getFields()) {
219-
System.out.println("Processing " + fd.getName());
220214
currY += FIELD_INTERVAL;
221215
FieldRectangle newNode = new FieldRectangle(currY, fd);
222216
fieldRectList.add(newNode);

src/org/ohdsi/rabbitInAHat/ETLSQLGenerator.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,10 @@
11
package org.ohdsi.rabbitInAHat;
22

3-
import java.util.AbstractMap;
43
import java.util.ArrayList;
5-
import java.util.Collection;
6-
import java.util.Comparator;
74
import java.util.HashMap;
85
import java.util.Iterator;
9-
import java.util.LinkedHashMap;
106
import java.util.List;
117
import java.util.Map;
12-
import java.util.Map.Entry;
13-
import java.util.Set;
148

159
import org.ohdsi.databases.DbType;
1610
import org.ohdsi.rabbitInAHat.dataModel.DataType;
@@ -25,8 +19,6 @@
2519
import org.ohdsi.utilities.exception.UnsupportedDataTypeException;
2620
import org.ohdsi.whiteRabbit.ObjectExchange;
2721

28-
import com.sun.xml.internal.ws.policy.privateutil.PolicyUtils.Collections;
29-
3022
public class ETLSQLGenerator {
3123

3224
public static final String HEADER_COMMENT = "# AUTOMATICALLY GENERATED BY RabbitInAHat\n# MUST USE WITH THE SAME DATABASE AS THE SOURCE TABLES\n\n";
@@ -205,7 +197,6 @@ public static Field getUniqueSourceField (Table sourceTable, Table targetTable)
205197
if (uniqueField == null) {
206198
return null;
207199
}
208-
Field sourceField = null;
209200
List<Mapping<Field>> allMaps = ObjectExchange.etl.getAllMaps();
210201
List<MappableItem> sourceFields = new ArrayList<>();
211202
for (Mapping<Field> map_ : allMaps) {

target/classes/Main$1.class

0 Bytes
Binary file not shown.

target/classes/Main$2$1.class

0 Bytes
Binary file not shown.

target/classes/Main$2$2.class

-234 Bytes
Binary file not shown.

target/classes/Main$2$3.class

0 Bytes
Binary file not shown.

target/classes/Main$2.class

0 Bytes
Binary file not shown.

target/classes/Main$3$1.class

0 Bytes
Binary file not shown.

0 commit comments

Comments
 (0)