Credit for contributors

[JimiHFord]

Describe the issue
It looks like I wasn't credited as a contributor to the project even though my Omada PR #96 was merged a while back. Could this be because of the way the maintainer had handled the PR? I'm not trying to throw shade 😄, just trying to figure out what caused this.

Screenshots
Visiting https://github.com/tteck/Proxmox/graphs/contributors you'll see that @JimiHFord doesn't show up 😢

Resolution
Could something be done to make sure I show up as a contributor? I am a HUGE fan of this project, and I want to keep contributing provided that I receive some small token of recognition.

[JimiHFord]

lol so I just fixed bug #1221 and now I'm showing up as a contributor! But I'm wondering if the author of the Omada commits shows up as @tteck 🤔 - haven't looked yet

[tteck]

Maybe the PR never made it to the main branch.

[tteck]

Or, maybe to be a Contributor, it has to go directly to the main branch?

[tteck]

It seems that if you make a commit to the pull-requests branch and I pull it into the main branch, you will be listed as a co-author. f8c38b8 I've noticed that Sergio is not listed in the contributors' list. Unfortunately, I don't know how to rectify this without pulling directly into the main branch, which I am hesitant to do.

[JimiHFord]

Unfortunately, co-author doesn't give full recognition to contributors. Right now, @Donkeykong307 is the only one that shows up as having made a significant contribution because his PR was merged direclty into main.

The only thing that shows up for me is my one-liner fix that got merged directly to main. My Omada contribution #96 doesn't show up.

https://github.com/tteck/Proxmox/graphs/contributors

Could you please consider altering your workflow to something like this:

• Contributor opens a PR (let's say PR#69, for instance) from contrib-username-fork:pr-branch ➡️ origin:main
• Maintainer(s) tests the PR
  • your workflow could look something like
    • git add remote contrib-username-fork [email protected]:contrib-username-fork/Proxmox.git
    • git fetch contrib-username-fork/pr-branch
    • git checkout contrib-username-fork/pr-branch
    • ./dev-utils/swap-urls.sh <all-the> <arguments-required> <to-update-the> <scripts-for-testing-on> <pr-69>
    • git push -u origin pr-branch:pr-69
    • run manual tests that test PR#69 in isolation of any other proposed changes
• If tests pass, maintainer(s) merge PR#69 into origin:main and delete origin:pr-69

I am happy to whip together a sed script and open a PR that does what you'd expect ./dev-utils/swap-urls.sh to do.

Not only will this give full recognition to contributors, but it will easily allow contributors to test their changes using their fork since they could use ./dev-utils/swap-urls.sh to test on their own fork and branch. Also, it would allow a maintainer to test multiple PRs in parallel in complete isolation of each other (e.g. pr-69, pr-70).

As an added bonus, if you adopt a workflow that attributes full recognition to contributors, I'll open up a PR that checks future pull requests for bash syntax errors via GitHub Actions. 😍

[tteck]

I take it that you missed last weeks commit d3b7ccc to the pull_request_template.md

[JimiHFord]

I saw that, but I didn't interpret that as a license to start opening up PRs against main. Thank you for your accommodation 🥳 !!