This repository was archived by the owner on Nov 2, 2024. It is now read-only.
ShellCheck #3716
Closed
JamesOBenson
started this conversation in
Ideas
ShellCheck
#3716
Replies: 1 comment
-
No thanks |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
We run our code through various tools, for shell, one of them is shellcheck. Your code is mostly clean, but I recommend a couple of small changes to help make it pass those verifications as well without impacting the performance or significant modifications. For example, in your post_pve_install.sh - there are only 2 issues:
Instead of:
You can use:
and likewise, instead of this:
use this:
Beta Was this translation helpful? Give feedback.
All reactions