Add switch to make Update all LXC script unattended?

[amlucent]

What I envision would work like this, add a -y or --unattended switch to allow the update LXC script to run unattended. This way it could be added to a pve server's crontab or even an ansible playbook to run across multiple pve hypervisors.

bash -c "$(wget -qLO - https://github.com/tteck/Proxmox/raw/main/misc/update-lxcs.sh)" -y

I have taken the liberty of posting my personal changes for your or anyones use. Such a small change i didnt feel like merited a fork or anything.

#!/bin/bash
set -e
YW=$(echo "\033[33m")
BL=$(echo "\033[36m")
RD=$(echo "\033[01;31m")
CM='\xE2\x9C\x94\033'
GN=$(echo "\033[1;92m")
CL=$(echo "\033[m")

if [[ $1 != -y ]]; then
  while true; do
    read -p "This Will Update All LXC Containers. Proceed(y/n)?" yn
    case $yn in
    [Yy]*) break ;;
    [Nn]*) exit ;;
    *) echo "Please answer yes or no." ;;
    esac
  done
  clear
fi

  function header_info {
    cat <<"EOF"
       __  __          __      __          __   _  ________
      / / / /___  ____/ /___ _/ /____     / /  | |/ / ____/
     / / / / __ \/ __  / __ `/ __/ _ \   / /   |   / /     
    / /_/ / /_/ / /_/ / /_/ / /_/  __/  / /___/   / /___   
    \____/ .___/\__,_/\__,_/\__/\___/  /_____/_/|_\____/   
        /_/                                                

EOF
}

  header_info

  containers=$(pct list | tail -n +2 | cut -f1 -d' ')

  function update_container() {
    container=$1
    clear
    header_info
    name=`pct exec $container hostname`
    echo -e "${BL}[Info]${GN} Updating ${BL}$container${CL} : ${GN}$name${CL} \n"
    pct config $container > temp
    os=`awk '/^ostype/' temp | cut -d' ' -f2`
    if [ "$os" == "alpine" ]; then
          pct exec $container -- ash -c "apk update && apk upgrade"
    elif [ "$os" == "ubuntu" ] || [ "$os" == "debian" ] || [ "$os" == "devuan" ]; then
          pct exec $container -- bash -c "apt-get update && apt-get upgrade -y && apt-get clean && apt-get --purge autoremove -y"
    elif [ "$os" == "fedora" ]; then
          pct exec $container -- bash -c "dnf -y update && dnf -y upgrade && dnf -y --purge autoremove"
    elif [ "$os" == "archlinux" ]; then
          pct exec $container -- bash -c "pacman -Syyu --noconfirm"
    else
          pct exec $container -- bash -c "yum -y update"
    fi
  }

if [[ $1 != -y ]]; then
  read -p "Skip stopped containers? " -n 1 -r
  echo
  if [[ ! $REPLY =~ ^[Yy]$ ]]; then
    skip=no
  else
    skip=yes
  fi
else
  skip=yes
fi

for container in $containers; do
  status=$(pct status $container)
  if [ "$skip" == "no" ]; then
    if [ "$status" == "status: stopped" ]; then
      echo -e "${BL}[Info]${GN} Starting${BL} $container ${CL} \n"
      pct start $container
      echo -e "${BL}[Info]${GN} Waiting For${BL} $container${CL}${GN} To Start ${CL} \n"
      sleep 5
      update_container $container
      echo -e "${BL}[Info]${GN} Shutting down${BL} $container ${CL} \n"
      pct shutdown $container &
    elif [ "$status" == "status: running" ]; then
      update_container $container
    fi
  fi
  if [ "$skip" == "yes" ]; then
    if [ "$status" == "status: running" ]; then
      update_container $container
    fi
  fi
done
wait
rm -rf temp
echo -e "${GN} Finished, All Containers Updated. ${CL} \n"

[tteck]

For a crontab, keep it simple, if it's running, update it. That way it skips templates.

#!/bin/bash
set -e
containers=$(pct list | tail -n +2 | cut -f1 -d' ')
function update_container() {
  container=$1
  pct config $container > temp
  os=`awk '/^ostype/' temp | cut -d' ' -f2`
  if [ "$os" == "alpine" ]; then
        pct exec $container -- ash -c "apk update && apk upgrade"
  elif [ "$os" == "ubuntu" ] || [ "$os" == "debian" ] || [ "$os" == "devuan" ]; then
        pct exec $container -- bash -c "apt-get update && apt-get upgrade -y && apt-get clean && apt-get --purge autoremove -y"
  elif [ "$os" == "fedora" ]; then
        pct exec $container -- bash -c "dnf -y update && dnf -y upgrade && dnf -y --purge autoremove"
  elif [ "$os" == "archlinux" ]; then
        pct exec $container -- bash -c "pacman -Syyu --noconfirm"
  else
        pct exec $container -- bash -c "yum -y update"
  fi
}
for container in $containers; do
  status=$(pct status $container)
if [ "$status" == "status: running" ]; then
    update_container $container
fi
done
wait
rm -rf temp