Skip to content

Commit 273d53b

Browse files
committed
Deploy fixes
@fixed PKG signing
1 parent 6118ba9 commit 273d53b

File tree

3 files changed

+13
-11
lines changed

3 files changed

+13
-11
lines changed

Formula/gather-cli.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,12 @@
77
class GatherCli < Formula
88
desc "Readability and Markdown utility for saving web urls and HTML text"
99
homepage "https://brettterpstra.com/projects/gather-cli/"
10-
version "2.1.9"
10+
version "2.1.10"
1111
license "MIT"
1212

1313
on_macos do
1414
url "https://github.com/ttscoff/gather-cli/releases/download/v#{version}/gather-cli-#{version}-macos-universal.tar.gz"
15-
sha256 "5a3d5922ebe5b5a936cd1276534c20811d184be68836526d54a9c036651df2e5"
15+
sha256 "55fe5e2243bfb0166a04f8e3234c02d012e510fe7776e7fc770231cee2884119"
1616
end
1717

1818
def install

scripts/package.sh

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -79,20 +79,22 @@ notarizefile() { # $1: path to file to notarize, $2: identifier
7979
xcrun swift build -c release --arch arm64 --arch x86_64
8080
bindir=$(xcrun swift build -c release --arch arm64 --arch x86_64 --show-bin-path)
8181

82-
# Determine signing identity (allow override via environment variable)
83-
APP_SIGNING_IDENTITY="${APP_SIGNING_IDENTITY:-Developer ID Installer: Brett Terpstra (47TRS7H4BH)}"
82+
# Determine signing identity for binary (allow override via environment variable)
83+
# Default to 3rd Party Mac Developer Application (for Mac App Store) or Developer ID Application (for direct distribution)
84+
APP_SIGNING_IDENTITY="${APP_SIGNING_IDENTITY:-3rd Party Mac Developer Application: Brett Terpstra (47TRS7H4BH)}"
85+
86+
# Initialize notarization flag - will be set based on PKG signing success
87+
SKIP_NOTARIZATION=true
8488

8589
# Check if the identity exists, if not use ad-hoc signing
8690
if security find-identity -v -p codesigning | grep -q "$APP_SIGNING_IDENTITY"; then
87-
echo "## Signing with: $APP_SIGNING_IDENTITY"
91+
echo "## Signing binary with: $APP_SIGNING_IDENTITY"
8892
codesign --force --verbose --sign "$APP_SIGNING_IDENTITY" -o runtime --timestamp $bindir/$executable
8993
codesign --verify -vvvv $bindir/$executable
90-
SKIP_NOTARIZATION=false
9194
else
92-
echo "## Warning: Identity '$APP_SIGNING_IDENTITY' not found, using ad-hoc signing"
95+
echo "## Warning: Identity '$APP_SIGNING_IDENTITY' not found, using ad-hoc signing for binary"
9396
codesign --force --verbose --sign "-" $bindir/$executable
9497
codesign --verify -vvvv $bindir/$executable
95-
SKIP_NOTARIZATION=true
9698
fi
9799

98100
rm -rf package
@@ -114,8 +116,8 @@ if [ -n "$INSTALLER_SIGNATURE" ] && [ "$INSTALLER_SIGNATURE" != "-" ]; then
114116
--sign "$INSTALLER_SIGNATURE" \
115117
"$pkgpath" 2>&1; then
116118
echo "## ✓ PKG signed successfully"
117-
# PKG is signed, can be notarized (if binary was also properly signed)
118-
# SKIP_NOTARIZATION remains false if binary was signed, true if ad-hoc
119+
# PKG is signed with Developer ID Installer, can be notarized
120+
SKIP_NOTARIZATION=false
119121
else
120122
PKG_BUILD_EXIT=$?
121123
echo "## Warning: Failed to sign with '$INSTALLER_SIGNATURE' (exit code: $PKG_BUILD_EXIT), building unsigned pkg"

src/_README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<!--README--><!--GITHUB-->![Howzit banner image](https://cdn3.brettterpstra.com/uploads/2022/08/gatherheader-rb.webp)<!--END GITHUB-->
44
<!--JEKYLL{% img aligncenter 800 220 /uploads/2022/08/gatherheader-rb.jpg "Howzit banner image" %}-->
55

6-
Current version: <!--VER-->2.1.9<!--END VER-->
6+
Current version: <!--VER-->2.1.10<!--END VER-->
77

88
This project is the successor to read2text, which was a Python based tool that used Arc90 Readability and html2text to convert web URLs to Markdown documents, ready to store in your notes. It takes its name from another of my similar projects that I've since retired. It was this, but with a GUI, and this is infinitely more scriptable and is designed to nestle into your favorite tools and projects.
99

0 commit comments

Comments
 (0)