Skip to content

[F&E]: SingleObservationSet check for duplicate observations #659

@jo11he

Description

@jo11he

Description:

Some ODF files (in the context of the cassini mission) result in duplicate observations (same epoch, same value) within the same SingleObservationSet. There could be a check (with user control) to eliminate these duplicates.

Suggestions for implementation:

Define a member function that identifies duplicates and using the existing eraseDuplicates by index member functions of SingleObservationSet removes them. This function should be called in the constructor, toggled by a boolean in the constructor signature. The boolean should default to false (no elimination of duplicates) to avoid inconsistencies between transfer of set data from old to new sets like in e.g. observation set splits.

Instead, I propose to use a boolean on the createOdfObservedObservationCollectionFromFile signature that connects to the first call of the SingleObservationSet constructor, which eliminates duplicates (if user wishes) right at the first creation of the ObservationCollection.

I am working on this already.

Additional context:

No response

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

Status

Issues with a PR

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions