Skip to content

Commit d7af624

Browse files
committed
(storing_groceries) re-add cabinet_inspect_area
1 parent 3039f0a commit d7af624

File tree

3 files changed

+6
-8
lines changed

3 files changed

+6
-8
lines changed

challenge_storing_groceries/src/challenge_storing_groceries/open_door.py

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -186,26 +186,23 @@ def execute(self, userdata=None):
186186

187187

188188
class OpenDoorMachine(smach.StateMachine):
189-
def __init__(self, robot, shelf_designator, cabinet_navigate_area="in_front_of"):
189+
def __init__(self, robot, shelf_designator, cabinet_navigate_area: str = "in_front_of", cabinet_inspect_area: str = "on_top_of"):
190190
smach.StateMachine.__init__(self, outcomes=["succeeded", "failed"])
191191

192-
self.shelfDes = shelf_designator
193-
cabinet_inspect_area = "Todo"
194-
195192
with self:
196193
smach.StateMachine.add("NAVIGATE_TO_CABINET",
197-
states.navigation.NavigateToSymbolic(robot, {self.shelfDes: cabinet_navigate_area}, self.shelfDes),
194+
states.navigation.NavigateToSymbolic(robot, {shelf_designator: cabinet_navigate_area}, shelf_designator),
198195
transitions={'arrived': 'UPDATE_CABINET_POSE',
199196
'unreachable': 'failed',
200197
'goal_not_defined': 'failed'})
201198

202199
smach.StateMachine.add("UPDATE_CABINET_POSE",
203-
UpdateCabinetPose(robot, self.shelfDes, cabinet_inspect_area),
200+
UpdateCabinetPose(robot, shelf_designator, cabinet_inspect_area),
204201
transitions={'succeeded': 'OPEN_DOOR',
205202
'failed': 'failed'})
206203

207204
smach.StateMachine.add("OPEN_DOOR",
208-
OpenDoor(robot, self.shelfDes),
205+
OpenDoor(robot, shelf_designator),
209206
transitions={'succeeded': 'succeeded',
210207
'failed': 'failed'})
211208

challenge_storing_groceries/src/challenge_storing_groceries/storing_groceries.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ def setup_statemachine(robot):
4444

4545
# open the door of the cabinet
4646
smach.StateMachine.add("OPEN_DOOR",
47-
OpenDoorMachine(robot, shelf_des),
47+
OpenDoorMachine(robot, shelf_des, cabinet_inspect_area=challenge_knowledge.cabinet_inspect_area),
4848
transitions={'succeeded': 'SAY_CLOSE_DOOR',
4949
'failed': 'SAY_UNABLE_TO_OPEN_DOOR'})
5050

robocup_knowledge/src/robocup_knowledge/environments/impuls/challenge_storing_groceries.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
# Detection
1111
shelf = "closet"
1212
default_area = "shelf4"
13+
cabinet_inspect_area = "shelf2"
1314
inspect_area = "in_front_of"
1415
object_shelves = ["shelf3", "shelf4", "shelf5"] # TODO unused variable?
1516
object_types = [obj["name"] for obj in common.objects] # TODO unused variable?

0 commit comments

Comments
 (0)