Merge pull request #219 from tulibraries/rspec-test-updates

update failing tests

Author: nomadicoder

spec/factories/migration_statuses.rb

@@ -6,6 +6,14 @@
     active { true }
     default { false }
 
+    initialize_with do
+      MigrationStatus.find_or_initialize_by(name: name).tap do |status|
+        status.active = active
+        status.default = default
+        status.save!
+      end
+    end
+
     trait :default do
       name { "Needs review" }
       default { true }

spec/models/isilon_asset_spec.rb

@@ -2,7 +2,7 @@
 require "rails_helper"
 
 RSpec.describe IsilonAsset, type: :model do
-  let!(:migration_status) { MigrationStatus.create!(name: "Needs review", active: true, default: true) }
+  let!(:migration_status) { FactoryBot.create(:migration_status, :default) }
 
   it "can be created with a migration status" do
     asset = IsilonAsset.create!(

spec/requests/admin/isilon_assets_spec.rb

@@ -2,7 +2,7 @@
 require 'rails_helper'
 
 RSpec.describe "Admin::IsilonAssets", type: :request do
-  let!(:migration_status) { MigrationStatus.create!(name: "Migrated", active: true) }
+  let!(:migration_status) { FactoryBot.create(:migration_status, :migrated) }
 
   let!(:aspace_collection) { AspaceCollection.create!(name: "Aspace Foo", active: true) }
 

spec/services/sync_service/assets_spec.rb

@@ -4,9 +4,9 @@
 
 RSpec.describe SyncService::Assets, type: :service do
   let!(:volume) { FactoryBot.create(:volume, name: "deposit") }
-  let!(:default_migration_status) { MigrationStatus.create!(name: "Needs review", active: true, default: true) }
-  let!(:migrated_status) { MigrationStatus.create!(name: "Migrated", active: true, default: false) }
-  let!(:dont_migrate_status) { MigrationStatus.create!(name: "Don't migrate", active: true, default: false) }
+  let!(:default_migration_status) { FactoryBot.create(:migration_status, :default) }
+  let!(:migrated_status) { FactoryBot.create(:migration_status, :migrated) }
+  let!(:dont_migrate_status) { FactoryBot.create(:migration_status, :dont_migrate) }
 
   describe '#apply_automation_rules' do
     let(:csv_path) { file_fixture('automation_rules_sync.csv').to_s }

spec/system/file_tree_column_filter_spec.rb

@@ -46,7 +46,7 @@
     find("[data-command='filter']", match: :first).click
     expect(page).to have_selector(".wb-popup", visible: true)
 
-    find("body").click
+    page.execute_script("document.dispatchEvent(new MouseEvent('mousedown', { bubbles: true }))")
     expect(page).to have_no_selector(".wb-popup", visible: true)
   end