Skip to content

Commit 5a4490c

Browse files
author
Túlio Ornelas
committed
Improve extract-json#allTextNodes performance
1 parent 5826a0d commit 5a4490c

File tree

3 files changed

+5
-8
lines changed

3 files changed

+5
-8
lines changed

extension/src/json-viewer/check-if-json.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
var extractJSON = require('./extract-json');
22

33
function allTextNodes(nodes) {
4-
return Object.keys(nodes).reduce(function(result, key) {
5-
return result && nodes[key].nodeName === '#text'
6-
}, true)
4+
return !Object.keys(nodes).some(function(key) {
5+
return nodes[key].nodeName !== '#text'
6+
})
77
}
88

99
function getPreWithSource() {
1010
var childNodes = document.body.childNodes;
1111

1212
if (childNodes.length === 0) {
13-
null
13+
return null
1414
}
1515

1616
if (childNodes.length > 1 && allTextNodes(childNodes)) {

package.json

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,6 @@
2121
"sweetalert": "1.0.x",
2222
"webpack": "1.12.x"
2323
},
24-
"engines": {
25-
"node": "7.0",
26-
"npm": "3.10"
27-
},
2824
"scripts": {
2925
"release": "NODE_ENV=production npm run build",
3026
"build": "./node_modules/.bin/webpack --progress --colors && node ./lib/release-script"

tests/geojson.json

Lines changed: 1 addition & 0 deletions
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)