test: add unit tests for ShellServer and ShellExecutor to ensure command handling and execution functionality

Author: tumf

tests/test_server.py

@@ -0,0 +1,41 @@
+import pytest
+from mcp_shell_server.server import ShellServer
+
+@pytest.fixture
+def server():
+    return ShellServer()
+
+@pytest.mark.asyncio
+async def test_server_handle_empty_request(server):
+    response = await server.handle({})
+    assert response["error"] == "No command provided"
+    assert response["status"] == 1
+
+@pytest.mark.asyncio
+async def test_server_handle_valid_command(server, monkeypatch):
+    monkeypatch.setenv("ALLOW_COMMANDS", "echo")
+    response = await server.handle({
+        "command": ["echo", "hello world"]
+    })
+    assert response["stdout"].strip() == "hello world"
+    assert response["status"] == 0
+    assert "execution_time" in response
+
+@pytest.mark.asyncio
+async def test_server_handle_stdin(server, monkeypatch):
+    monkeypatch.setenv("ALLOW_COMMANDS", "cat")
+    response = await server.handle({
+        "command": ["cat"],
+        "stdin": "test input"
+    })
+    assert response["stdout"].strip() == "test input"
+    assert response["status"] == 0
+
+@pytest.mark.asyncio
+async def test_server_handle_invalid_command(server, monkeypatch):
+    monkeypatch.setenv("ALLOW_COMMANDS", "echo")
+    response = await server.handle({
+        "command": ["invalid_command"]
+    })
+    assert response["error"] == "Command not allowed: invalid_command"
+    assert response["status"] == 1

tests/test_shell_executor.py

@@ -0,0 +1,57 @@
+import os
+import pytest
+from mcp_shell_server.shell_executor import ShellExecutor
+
+@pytest.fixture
+def executor():
+    return ShellExecutor()
+
+@pytest.mark.asyncio
+async def test_basic_command_execution(executor, monkeypatch):
+    monkeypatch.setenv("ALLOW_COMMANDS", "echo,ls")
+    result = await executor.execute(["echo", "hello"])
+    assert result["stdout"].strip() == "hello"
+    assert result["status"] == 0
+    assert result["stderr"] == ""
+    assert "execution_time" in result
+
+@pytest.mark.asyncio
+async def test_stdin_input(executor, monkeypatch):
+    monkeypatch.setenv("ALLOW_COMMANDS", "cat")
+    result = await executor.execute(["cat"], stdin="hello world")
+    assert result["stdout"].strip() == "hello world"
+    assert result["status"] == 0
+
+@pytest.mark.asyncio
+async def test_command_not_allowed(executor, monkeypatch):
+    monkeypatch.setenv("ALLOW_COMMANDS", "ls")
+    result = await executor.execute(["rm", "-rf", "/"])
+    assert result["error"] == "Command not allowed: rm"
+    assert result["status"] == 1
+
+@pytest.mark.asyncio
+async def test_empty_command(executor):
+    result = await executor.execute([])
+    assert result["error"] == "Empty command"
+    assert result["status"] == 1
+
+@pytest.mark.asyncio
+async def test_command_with_space_in_allow_commands(executor, monkeypatch):
+    monkeypatch.setenv("ALLOW_COMMANDS", "ls, echo ,cat")
+    result = await executor.execute(["echo", "test"])
+    assert result["stdout"].strip() == "test"
+    assert result["status"] == 0
+
+@pytest.mark.asyncio
+async def test_multiple_commands_with_operator(executor, monkeypatch):
+    monkeypatch.setenv("ALLOW_COMMANDS", "echo,ls")
+    result = await executor.execute(["echo", "hello", ";", "ls", "-l"])
+    assert "Command not allowed: ls" in result["error"]
+    assert result["status"] == 1
+
+@pytest.mark.asyncio
+async def test_command_with_error_output(executor, monkeypatch):
+    monkeypatch.setenv("ALLOW_COMMANDS", "ls")
+    result = await executor.execute(["ls", "/nonexistent"])
+    assert result["stderr"] != ""
+    assert result["status"] != 0