Skip to content

Commit f65b481

Browse files
authored
fix that wrong command was used when mixed DNS servers were being set (#16)
1 parent 38e8499 commit f65b481

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/util.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,16 +193,17 @@ pub(crate) fn set_interface_dns_servers_via_cmd(adapter: &str, dns: &[IpAddr]) -
193193
if dns.is_empty() {
194194
return Ok(());
195195
}
196-
let ip_str = if dns[0].is_ipv4() { "ipv4" } else { "ipv6" };
197196

198197
// netsh interface ipv4 set dns name="MyAdapter" source="static" address="8.8.8.8"
199198
// netsh interface ipv4 add dns name="MyAdapter" index=2 address="8.8.4.4"
199+
let ip_str = if dns[0].is_ipv4() { "ipv4" } else { "ipv6" };
200200
let name = format!("name=\"{}\"", adapter);
201201
let addr = format!("address=\"{}\"", dns[0]);
202202
let args = vec!["interface", ip_str, "set", "dns", &name, "source=\"static\"", &addr];
203203
run_command("netsh", &args)?;
204204
let mut index = 2;
205205
for dns in dns.iter().skip(1) {
206+
let ip_str = if dns.is_ipv4() { "ipv4" } else { "ipv6" };
206207
let addr = format!("address=\"{}\"", dns);
207208
let idx = format!("index={}", index);
208209
let args = vec!["interface", ip_str, "add", "dns", &name, &idx, &addr];

0 commit comments

Comments
 (0)