Skip to content

Commit dcdbab1

Browse files
authored
Merge pull request #56 from tuna-os/copilot/remove-stable-testing-promotion
Remove promotion pipeline, implement weekly builds with coreos akmods
2 parents 4905147 + 3840b0a commit dcdbab1

File tree

11 files changed

+173
-525
lines changed

11 files changed

+173
-525
lines changed

.github/copilot-instructions.md

Lines changed: 24 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,18 @@ sudo just iso yellowfin base local
3939
## Working Effectively
4040

4141
### Dependencies and Setup
42-
- Install Just command runner to a temp dir not the root of the repo: `mkdir -p /tmp/just && cd /tmp/just && wget https://github.com/casey/just/releases/download/1.32.0/just-1.32.0-x86_64-unknown-linux-musl.tar.gz -O just.tar.gz && tar xzf just.tar.gz && sudo mv just /usr/local/bin/ && cd - && rm -rf /tmp/just`
42+
- **Install Just via Homebrew** (recommended for consistency with CI):
43+
```bash
44+
# Install Homebrew if not already installed
45+
/bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/HEAD/install.sh)"
46+
47+
# Install just
48+
brew install just
49+
```
50+
- **Alternative**: Install Just from GitHub releases to a temp dir (not recommended):
51+
```bash
52+
mkdir -p /tmp/just && cd /tmp/just && wget https://github.com/casey/just/releases/download/1.32.0/just-1.32.0-x86_64-unknown-linux-musl.tar.gz -O just.tar.gz && tar xzf just.tar.gz && sudo mv just /usr/local/bin/ && cd - && rm -rf /tmp/just
53+
```
4354
- **CRITICAL**: NEVER extract just or any other tools directly into the repository root as this will overwrite project files like LICENSE and README.md
4455
- Podman is required for container builds (usually pre-installed in CI environments)
4556
- Shellcheck is required for linting: `sudo apt-get update && sudo apt-get install -y shellcheck`
@@ -143,8 +154,17 @@ For changes that don't affect the build process (e.g., documentation, CI config)
143154

144155
## Development Workflow
145156

157+
### Pre-Commit Requirements (MANDATORY):
158+
Before making any commit, you MUST run these commands in order:
159+
160+
1. **Format code**: `just fix` - Formats shell scripts and Just files
161+
2. **Validate syntax**: `just check` - Checks all scripts, YAML, JSON, and Just files
162+
3. **Review changes**: `git status` and `git diff` - Verify what will be committed
163+
164+
**CRITICAL**: Running `just fix` and `just check` before every commit is mandatory. This prevents CI failures and ensures code quality. See `AGENTS.md` for detailed guidelines.
165+
146166
### Making Changes:
147-
1. **Always run syntax checks first**: `just check`
167+
1. **Always run `just fix` then `just check` before committing**: This is mandatory, not optional
148168
2. **Test locally before pushing**: Build at least one variant to verify changes work
149169
3. **Respect build timing**: Allow 45-60 minutes for full builds, never cancel early
150170
4. **CI Integration**: All changes must pass GitHub Actions workflow within 60-minute timeout
@@ -236,7 +256,8 @@ Build arguments passed to Podman:
236256
### Critical Don'ts:
237257
- **NEVER cancel builds early**: Builds take 45-60 minutes, canceling early wastes resources
238258
- **NEVER extract tools to repo root**: Always use /tmp or other temporary directories to avoid overwriting project files
239-
- **NEVER skip validation**: Always run `just check` before committing changes
259+
- **NEVER skip `just fix` and `just check`**: ALWAYS run both commands before committing - this is mandatory
260+
- **NEVER commit without validation**: Running `just fix` then `just check` before every commit prevents CI failures
240261
- **NEVER commit build artifacts**: Use `.gitignore` to exclude `.build/`, `.rpm-cache-*`, and similar directories
241262

242263
### Build Best Practices:

.github/workflows/build-iso.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -194,8 +194,11 @@ jobs:
194194
- name: Checkout
195195
uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v5
196196

197-
- name: Setup Just
198-
uses: extractions/setup-just@e33e0265a09d6d736e2ee1e0eb685ef1de4669ff # v3
197+
- name: Setup Homebrew
198+
uses: Homebrew/actions/setup-homebrew@master
199+
200+
- name: Install Just via Homebrew
201+
run: brew install just
199202

200203
- name: Check Just Syntax
201204
shell: bash

.github/workflows/build-next.yml

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
1-
name: Build Next Image
1+
name: Build Weekly Images
22
on:
3-
push:
4-
branches:
5-
- main
6-
- coreos
3+
schedule:
4+
# Run every Tuesday at 1am UTC (weekly builds)
5+
- cron: "0 1 * * TUE"
76
workflow_dispatch:
87
inputs:
98
variant:
@@ -160,7 +159,7 @@ jobs:
160159
image-variant: ${{ matrix.variant }}
161160
flavor: base
162161
platforms: ${{ matrix.platforms }}
163-
default-tag: next
162+
default-tag: latest
164163
rechunk: true
165164
sbom: false
166165
publish: true
@@ -186,7 +185,7 @@ jobs:
186185
image-variant: ${{ matrix.variant }}
187186
flavor: dx
188187
platforms: ${{ matrix.platforms }}
189-
default-tag: next
188+
default-tag: latest
190189
rechunk: true
191190
sbom: false
192191
publish: true
@@ -212,7 +211,7 @@ jobs:
212211
image-variant: ${{ matrix.variant }}
213212
flavor: gdx
214213
platforms: ${{ matrix.platforms }}
215-
default-tag: next
214+
default-tag: latest
216215
rechunk: true
217216
sbom: false
218217
publish: true

.github/workflows/promote-to-testing.yml

Lines changed: 0 additions & 174 deletions
This file was deleted.

.github/workflows/release-stable.yml

Lines changed: 0 additions & 111 deletions
This file was deleted.

0 commit comments

Comments
 (0)