fix: typos and other CodeRabbit suggestions

Signed-off-by: tunnckoCore <5038030+tunnckoCore@users.noreply.github.com>

Author: tunnckoCore

.rules/zagora.md

@@ -85,8 +85,8 @@ import {
   isZagoraError,
 } from 'zagora/errors';
 
-import * ZagoraTypes from 'zagora/types';
-import * zagoraUtils from 'zagora/utils';
+import * as ZagoraTypes from 'zagora/types';
+import * as zagoraUtils from 'zagora/utils';
 ```
 
 ## Creating procedures
@@ -113,8 +113,8 @@ const result = agent({ name: 'Alice' });
 - oRPC/tRPC - `.handler(({ input, context }) => {})` - always a single object
 - zagora with primitive input (string, object, array) - `.handler(({ context }, input) => {})` 
 - zagora with tuple schemas (spreaded args) - `.handler(({ context }, name, age) => {})` 
-- zagora with errprs map - `.errors({ NOT_FOUND: z.object({ id: z.string() })}).handler(({ context, errors }, name, age) => {})`
-- zagora without options object - `zagora({ disableOptions: true }).input(z.string()).handle((input) => input)`
+- zagora with errors map - `.errors({ NOT_FOUND: z.object({ id: z.string() })}).handler(({ context, errors }, name, age) => {})`
+- zagora without options object - `zagora({ disableOptions: true }).input(z.string()).handler((input) => input)`
 
 ## Input and Output Validation
 
@@ -151,7 +151,7 @@ const safeApi = zagora()
   .handler(({ env }) => {
     // env: { DATABASE_URL: string, JWT_SECRET: string, PORT: number }
     return a + b + env.PORT;
-  });
+  })
   // NOTE: you may need to cast with `as any` beause process.env differs from the schema!
   .callable({ env: process.env });
 
@@ -237,7 +237,7 @@ For simpler procedures and API look, enable auto-callable mode to skip `.callabl
 const simpleProcedure = zagora({ autoCallable: true, disableOptions: true })
   .input(z.tuple([z.string(), z.number().default(10)]))
   .output(z.string())
-  .handler((str, num) => input.toUpperCase());
+  .handler((str, num) => str.toUpperCase());
 
 const result = simpleProcedure('hello'); // Direct call
 ```
@@ -267,28 +267,28 @@ const asyncAgent = zagora()
 
 Agents built with Zagora are composable, testable, and maintain type safety throughout the application lifecycle.
 
+---
+
 ## Rules and Special Notes for Zagora usage
 
 The following rules outlines critical points, edge cases, and things to be careful about when using Zagora. These are derived from specially noted sections, examples, and warnings in the documentation.
 
-## Error Handling
+### Error Handling Cautions
 
-### Uppercase Error Keys
+#### Uppercase Error Keys
 - **Caution**: All keys in the error map must be uppercased (e.g., `NOT_FOUND`, not `not_found`). TypeScript will report a type error if not.
 - **Why**: These keys represent error "kinds" and are used in `result.error.kind`.
 
-### Error Helper Validation
+#### Error Helper Validation
 - **Caution**: If you pass invalid or missing keys to error helpers (e.g., `errors.NOT_FOUND({ invalidKey: 'value' })`), you get a `VALIDATION_ERROR` with a `key` property indicating which error validation failed.
 - **Example**: `throw errors.RATE_LIMIT({ retryAfter: 'invalid' })` → `VALIDATION_ERROR` because `retryAfter` expects a number.
 - **Tip**: Use `.strict()` on error schemas to throw on unknown keys: `z.object({...}).strict()`.
 
-### Error Type Guards
+#### Error Type Guards
 - **Caution**: Use `isValidationError`, `isInternalError`, `isDefinedError`, `isZagoraError` to narrow error types safely.
 - **Note**: Even syntax errors in handlers return `ZagoraResult` with error, never crashing the process.
 
-## Context Management
-
-### Context Merging
+### Context Merging and Management
 - **Caution**: Initial context (from `.context()`) is deep-merged with runtime context (from `.callable({ context })`).
 - **Example**: `.context({ userId: 'default' })` + `.callable({ context: { foo: 'bar' } })` → merged `{ userId: 'default', foo: 'bar' }`.
 - **Tip**: Useful for dependency injection; override at execution site (e.g., in server handlers).

AGENTS.md

@@ -85,8 +85,8 @@ import {
   isZagoraError,
 } from 'zagora/errors';
 
-import * ZagoraTypes from 'zagora/types';
-import * zagoraUtils from 'zagora/utils';
+import * as ZagoraTypes from 'zagora/types';
+import * as zagoraUtils from 'zagora/utils';
 ```
 
 ## Creating procedures
@@ -113,8 +113,8 @@ const result = agent({ name: 'Alice' });
 - oRPC/tRPC - `.handler(({ input, context }) => {})` - always a single object
 - zagora with primitive input (string, object, array) - `.handler(({ context }, input) => {})` 
 - zagora with tuple schemas (spreaded args) - `.handler(({ context }, name, age) => {})` 
-- zagora with errprs map - `.errors({ NOT_FOUND: z.object({ id: z.string() })}).handler(({ context, errors }, name, age) => {})`
-- zagora without options object - `zagora({ disableOptions: true }).input(z.string()).handle((input) => input)`
+- zagora with errors map - `.errors({ NOT_FOUND: z.object({ id: z.string() })}).handler(({ context, errors }, name, age) => {})`
+- zagora without options object - `zagora({ disableOptions: true }).input(z.string()).handler((input) => input)`
 
 ## Input and Output Validation
 
@@ -151,7 +151,7 @@ const safeApi = zagora()
   .handler(({ env }) => {
     // env: { DATABASE_URL: string, JWT_SECRET: string, PORT: number }
     return a + b + env.PORT;
-  });
+  })
   // NOTE: you may need to cast with `as any` beause process.env differs from the schema!
   .callable({ env: process.env });
 
@@ -237,7 +237,7 @@ For simpler procedures and API look, enable auto-callable mode to skip `.callabl
 const simpleProcedure = zagora({ autoCallable: true, disableOptions: true })
   .input(z.tuple([z.string(), z.number().default(10)]))
   .output(z.string())
-  .handler((str, num) => input.toUpperCase());
+  .handler((str, num) => str.toUpperCase());
 
 const result = simpleProcedure('hello'); // Direct call
 ```
@@ -267,28 +267,28 @@ const asyncAgent = zagora()
 
 Agents built with Zagora are composable, testable, and maintain type safety throughout the application lifecycle.
 
+---
+
 ## Rules and Special Notes for Zagora usage
 
 The following rules outlines critical points, edge cases, and things to be careful about when using Zagora. These are derived from specially noted sections, examples, and warnings in the documentation.
 
-## Error Handling
+### Error Handling Cautions
 
-### Uppercase Error Keys
+#### Uppercase Error Keys
 - **Caution**: All keys in the error map must be uppercased (e.g., `NOT_FOUND`, not `not_found`). TypeScript will report a type error if not.
 - **Why**: These keys represent error "kinds" and are used in `result.error.kind`.
 
-### Error Helper Validation
+#### Error Helper Validation
 - **Caution**: If you pass invalid or missing keys to error helpers (e.g., `errors.NOT_FOUND({ invalidKey: 'value' })`), you get a `VALIDATION_ERROR` with a `key` property indicating which error validation failed.
 - **Example**: `throw errors.RATE_LIMIT({ retryAfter: 'invalid' })` → `VALIDATION_ERROR` because `retryAfter` expects a number.
 - **Tip**: Use `.strict()` on error schemas to throw on unknown keys: `z.object({...}).strict()`.
 
-### Error Type Guards
+#### Error Type Guards
 - **Caution**: Use `isValidationError`, `isInternalError`, `isDefinedError`, `isZagoraError` to narrow error types safely.
 - **Note**: Even syntax errors in handlers return `ZagoraResult` with error, never crashing the process.
 
-## Context Management
-
-### Context Merging
+### Context Merging and Management
 - **Caution**: Initial context (from `.context()`) is deep-merged with runtime context (from `.callable({ context })`).
 - **Example**: `.context({ userId: 'default' })` + `.callable({ context: { foo: 'bar' } })` → merged `{ userId: 'default', foo: 'bar' }`.
 - **Tip**: Useful for dependency injection; override at execution site (e.g., in server handlers).

README.md

@@ -171,7 +171,7 @@ They are built around the network, Zagora is built around functions with excelle
 
 - Zagora is focused on producing "just functions", not networks, routers, or groups.
 - oRPC and tRPC does not "support" creating synchornous functions, they always are async
-  + in contrast, Zagora does not use `async/await `anywhere in the codebase, but `instanceof Promise` checks
+  + in contrast, Zagora does not use `async/await` anywhere in the codebase, but `instanceof Promise` checks
   + the return type of Zagora procedures is dynamically inferred based on many factors
   - return type is NOT a union like `ZagoraResult | Promise<ZagoraResult>` which gives amazing DX
 - oRPC/tRPC cannot create procedures that look like regular functions, they always accept a single object
@@ -296,13 +296,12 @@ if (res.ok) {
 }
 ```
 
-[Back to top](#table-of-contents)
-
-### Error Type Guards
 Isn't it amazing? You will never see `Error` or `try/catch` blocks again, and everything is typed top to bottom, well-known and intuitive.
 
 But wait, there's more: **Type Guards**!
 
+[Back to top](#table-of-contents)
+
 ### Error Type Guards
 
 Since you may want to differentiate between the error kinds, there are couple of helper type guards that you can use to narrow down the error.
@@ -424,7 +423,7 @@ hello('ok');
 
 hello('missing-required-keys');
 // result.error => { kind: 'VALIDATION_ERROR', key: 'RATE_LIMIT', issues: Schema.Issue[] }
-// result.error.issues - will contain the issue that `userId` and `messatge` are required
+// result.error.issues - will contain the issue that `userId` and `message` are required
 
 hello('invalid-keys');
 // result.error => { kind: 'VALIDATION_ERROR', key: 'RATE_LIMIT', issues: Schema.Issue[] }

package.json

@@ -44,7 +44,8 @@
   "scripts": {
     "prebuild": "bun run check:types",
     "build": "bunx tsdown",
-    "check": "bun run check:format && bun run check:types && bun run check:repo",
+    "check": "bun run check:copy-rules && bun run check:format && bun run check:types && bun run check:repo",
+    "check:copy-rules": "cp AGENTS.md .rules/zagora.md",
     "check:format": "bunx @biomejs/biome check --fix --unsafe",
     "check:types": "bunx tsgo-dev -p ./tsconfig.json",
     "check:repo": "bunx sherif -r root-package-dependencies -r root-package-private-field",

src/errors.ts

@@ -67,7 +67,7 @@ export function createValidationError<ErrorKindNames = never>(
   const issuesMsg = issues
     // strip "input" cuz it can be confusing when we are schema validating output and errors too
     .map((issue) => {
-      const key = issue.path?.join(".");
+      const key = issue.path?.join(".") || "(root)";
       const message = issue.message.replace("Invalid input: ", "");
       return `${key} => ${message}`;
     })

src/index.ts

@@ -407,7 +407,7 @@ export class Zagora<
 
           const { isAsync, handlerFailed, ...rest } = st;
 
-          // if handler failed, then we need to validate the error if errorShema,
+          // if handler failed, then we need to validate the error if errorSchema,
           // otherwise we can passthrough the Result object whatever it is.
           return handlerFailed
             ? validateError<TKindNames>(errorsMap as any, st.error, isAsync)

src/utils.ts

@@ -263,7 +263,7 @@ export function deepMerge(target: any, source: any): any {
   if (target == null || typeof target !== "object") return source;
   const result = Array.isArray(target) ? [...target] : { ...target };
   for (const key in source) {
-    if (key in source) {
+    if (Object.hasOwn(source, key)) {
       if (typeof source[key] === "object" && source[key] !== null) {
         result[key] = deepMerge(target[key], source[key]);
       } else {

test/main.test.ts

@@ -474,7 +474,7 @@ test("multiple procedures (calculator) from single instance (autoCallable:true)"
   }
 });
 
-test("handle optional/default valaues in object schemas", async () => {
+test("handle optional/default values in object schemas", async () => {
   const SpeedSchema = z.enum(["slow", "normal", "fast"]);
   const NumberSchema = z
     .string()
@@ -754,14 +754,14 @@ test("cache adapter passed through `.callable` method", async () => {
     expect((res2 as any).data).toStrictEqual(11);
   }
 
-  fixture();
-  fixture(true);
-  fixture(true, true);
-  fixture(false, true);
-  fixture(false, true, true);
-  fixture(true, false);
-  fixture(true, true, false);
-  fixture(false, false, true);
+  await fixture();
+  await fixture(true);
+  await fixture(true, true);
+  await fixture(false, true);
+  await fixture(false, true, true);
+  await fixture(true, false);
+  await fixture(true, true, false);
+  await fixture(false, false, true);
 });
 
 test("failing env validation schema through `.env` method", () => {