Skip to content

Commit 16cd5ef

Browse files
committed
Generator: Make sampler settings optional instead of default arg
1 parent 9089596 commit 16cd5ef

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

exllamav2/generator/dynamic.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -655,7 +655,7 @@ def generate(
655655
assert False, "Unexpected type in prompt"
656656

657657
if gen_settings is None:
658-
p_settings = ExLlamaV2Sampler.Settings()
658+
p_settings = None
659659
elif isinstance(gen_settings, ExLlamaV2Sampler.Settings):
660660
p_settings = gen_settings
661661
elif isinstance(gen_settings, list):
@@ -1536,7 +1536,7 @@ def __init__(
15361536
max_new_tokens: int,
15371537
min_new_tokens: int = 0,
15381538
max_skips: int | None = 4,
1539-
gen_settings: ExLlamaV2Sampler.Settings = ExLlamaV2Sampler.Settings(),
1539+
gen_settings: ExLlamaV2Sampler.Settings | None = None,
15401540
seed: int = None,
15411541
stop_conditions: list | tuple | set = None,
15421542
decode_special_tokens: bool = False,
@@ -1629,6 +1629,9 @@ def __init__(
16291629
self.max_skips = max_skips
16301630
self.allocated_pages = None
16311631

1632+
if gen_settings is None:
1633+
gen_settings = ExLlamaV2Sampler.Settings()
1634+
16321635
# Prepare sequences
16331636

16341637
if not isinstance(input_ids, list):

0 commit comments

Comments
 (0)