bug(ui): relative bar lengths in check results

[lucascherzer]

Describe the bug
The relative lengths of the bars indicating the ratio at which a check has succeeded vs failed in the UI are not accurately conveying the actual ratio.

Powerpipe version (powerpipe -v)
v1.4.0

To reproduce
Run any benchmark.

Expected behavior

• The green and red columns should have lengths that depict the ratio accurately
• Instead, green is consistently larger, even if the numbers do not match this (see screenshot)

Additional context
none

[pskrbasu]

@lucascherzer Thank you for pointing it out! We will get this fixed.

[pskrbasu]

Hey @lucascherzer we could not reproduce the exact issue, but we were able to get a potential fix for it. However, since we could not reproduce it with our available data, we could not test the fix out.

Will it be possible for you to re-test with a local build(our branch) and see how your data looks?

• Check out branch issue-945-summary-chart-widths
• cd ui/dashboard
• make run-local

If you have a Powerpipe server running on localhost on the default port, then the dev UI will connect to it.

Let us know!
Thanks

[lucascherzer]

I will see if I can get it to run on monday. Thanks for your work 👍

[lucascherzer]

Hi, I got it to run as you described, but the mods are never shown. The loading spinner keeps on going forever:

[MichaelBurgess]

@lucascherzer are you running a local Powerpipe server? E.g. inside a mod folder powerpipe server, which will provide the web socket to connect to on ws://localhost:9033/ws?

If you are, could you share any errors you see in the browser console?

[lucascherzer]

are you running a local Powerpipe server?

Good catch. That was it.

The fixes seem to have worked. But when I expand a top level control group (a benchmark in the puppet files), its childrens bars are only rendered when interacting with them by clicking:

After expanding the benchmark	After (twice 1) clicking one of the controls

Footnotes

1. The bars already appreared after the first click, but to collapse it again, I clicked a second time, so the subsequent controls can be seen in the screenshot ↩

[MichaelBurgess]

Sorry @lucascherzer - please could you get latest and check again?

[lucascherzer]

That did the job, it now works as expected 👍

[MichaelBurgess]

That did the job, it now works as expected 👍

Thanks for confirming @lucascherzer - we'll get this one merged in and released.

[lucascherzer]

Awesome. Thanks for your work