Skip to content

Commit 8ce7b99

Browse files
committed
Fix tests to not log errors
1 parent 07a4538 commit 8ce7b99

File tree

6 files changed

+24
-18
lines changed

6 files changed

+24
-18
lines changed

.github/workflows/build.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ jobs:
116116
if: ${{ always() }}
117117
with:
118118
name: unit-test-report
119-
path: '**/target/surefire-reports/*.xml'
119+
path: '**/target/cucumber-reports/*.xml'
120120
if-no-files-found: error
121121
retention-days: 2
122122

@@ -125,7 +125,7 @@ jobs:
125125
uses: turing85/publish-report@v2
126126
with:
127127
report-name: Unit Test
128-
report-path: '**/target/surefire-reports/*.xml'
128+
report-path: '**/target/cucumber-reports/*.xml'
129129

130130
owasp:
131131
name: OWASP Scan
Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,9 @@
11
package de.turing85.spring.fileupload;
22

3-
import io.cucumber.spring.CucumberContextConfiguration;
43
import org.junit.platform.suite.api.SelectClasspathResource;
54
import org.junit.platform.suite.api.Suite;
6-
import org.springframework.boot.test.context.SpringBootTest;
7-
import org.springframework.test.context.ContextConfiguration;
85

96
@Suite
107
@SelectClasspathResource("de/turing85/spring/fileupload")
11-
@CucumberContextConfiguration
12-
@ContextConfiguration(classes = FileUploadApplication.class)
13-
@SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT)
14-
class FileUploadCucumberTest {
8+
public class FileUploadCucumberTest {
159
}

src/test/java/de/turing85/spring/fileupload/TestApplication.java renamed to src/test/java/de/turing85/spring/fileupload/config/CucumberTestConfiguration.java

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,30 +1,28 @@
1-
package de.turing85.spring.fileupload;
1+
package de.turing85.spring.fileupload.config;
22

33
import java.net.URI;
44

55
import de.turing85.spring.fileupload.actor.FileUploadActor;
66
import io.cucumber.spring.ScenarioScope;
77
import org.springframework.beans.factory.annotation.Value;
8-
import org.springframework.boot.autoconfigure.SpringBootApplication;
8+
import org.springframework.boot.test.context.TestConfiguration;
99
import org.springframework.boot.test.web.server.LocalServerPort;
1010
import org.springframework.context.annotation.Bean;
1111
import org.springframework.context.annotation.Profile;
1212

13-
@SpringBootApplication
14-
class TestApplication {
13+
@TestConfiguration
14+
public class CucumberTestConfiguration {
1515
@Bean
1616
@ScenarioScope
1717
@Profile("test")
18-
static FileUploadActor testActor(
19-
@SuppressWarnings("SpringJavaInjectionPointsAutowiringInspection")
20-
@LocalServerPort int port) {
18+
FileUploadActor testActor(@LocalServerPort int port) {
2119
return new FileUploadActor(URI.create("http://localhost:%d".formatted(port)));
2220
}
2321

2422
@Bean
2523
@ScenarioScope
2624
@Profile("e2e")
27-
static FileUploadActor e2eActor(@Value("${sut.url}") URI sutUrl) {
25+
FileUploadActor e2eActor(@Value("${sut.url}") URI sutUrl) {
2826
return new FileUploadActor(sutUrl);
2927
}
3028
}

src/test/java/de/turing85/spring/fileupload/steps/FileUploadSteps.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import lombok.RequiredArgsConstructor;
99

1010
@RequiredArgsConstructor
11+
@SuppressWarnings("unused")
1112
public class FileUploadSteps {
1213
private final FileUploadActor actor;
1314

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
package de.turing85.spring.fileupload.steps;
2+
3+
import de.turing85.spring.fileupload.config.CucumberTestConfiguration;
4+
import io.cucumber.spring.CucumberContextConfiguration;
5+
import org.springframework.boot.test.context.SpringBootTest;
6+
7+
@CucumberContextConfiguration
8+
@SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT,
9+
classes = CucumberTestConfiguration.class)
10+
@SuppressWarnings("unused")
11+
class GlueConfig {
12+
}
Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
1-
cucumber.plugin=pretty, html:target/cucumber-reports/cucumber.html, json:target/cucumber-reports/cucumber.json, junit:target/cucumber-reports/cucumber.xml
1+
cucumber.glue = de.turing85.spring.fileupload.steps
2+
cucumber.plugin = pretty, html:target/cucumber-reports/cucumber.html, json:target/cucumber-reports/cucumber.json, junit:target/cucumber-reports/cucumber.xml

0 commit comments

Comments
 (0)