Merge branch 'gf/maintenance-is-needed-fix'

gitster · gitster · commit 2365d4f61212 · 2025-12-30T12:58:20.000+09:00
Brown-paper-bag fix to a recently graduated
'kn/maintenance-is-needed' topic.

* gf/maintenance-is-needed-fix:
  refs: dereference the value of the required pointer
diff --git a/refs/debug.c b/refs/debug.c
@@ -139,7 +139,7 @@ static int debug_optimize_required(struct ref_store *ref_store,
 	struct debug_ref_store *drefs = (struct debug_ref_store *)ref_store;
 	int res = drefs->refs->be->optimize_required(drefs->refs, opts, required);
 	trace_printf_key(&trace_refs, "optimize_required: %s, res: %d\n",
-			 required ? "yes" : "no", res);
+			 *required ? "yes" : "no", res);
 	return res;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -139,7 +139,7 @@ static int debug_optimize_required(struct ref_store *ref_store,`
`139`	`139`	`struct debug_ref_store drefs = (struct debug_ref_store )ref_store;`
`140`	`140`	`int res = drefs->refs->be->optimize_required(drefs->refs, opts, required);`
`141`	`141`	`trace_printf_key(&trace_refs, "optimize_required: %s, res: %d\n",`
`142`		`- required ? "yes" : "no", res);`
	`142`	`+ *required ? "yes" : "no", res);`
`143`	`143`	`return res;`
`144`	`144`	`}`
`145`	`145`