Fix phpGH-19962: arrayIndexThenCheck static analysis warning in firebird

ndossche · ndossche · commit bae78c614a44 · 2025-12-28T13:08:40.000+01:00
Same as ce534c6.
diff --git a/ext/pdo_firebird/firebird_statement.c b/ext/pdo_firebird/firebird_statement.c
@@ -172,7 +172,7 @@ static int firebird_stmt_execute(pdo_stmt_t *stmt) /* {{{ */
 					if (result_size > sizeof(result)) {
 						goto error;
 					}
-					while (result[i] != isc_info_end && i < result_size) {
+					while (i < result_size && result[i] != isc_info_end) {
 						short len = (short) isc_vax_integer(&result[i + 1], 2);
 						if (len != 1 && len != 2 && len != 4) {
 							goto error;

Original file line number	Diff line number	Diff line change
`@@ -172,7 +172,7 @@ static int firebird_stmt_execute(pdo_stmt_t stmt) / {{{ */`
`172`	`172`	`if (result_size > sizeof(result)) {`
`173`	`173`	`goto error;`
`174`	`174`	`}`
`175`		`- while (result[i] != isc_info_end && i < result_size) {`
	`175`	`+ while (i < result_size && result[i] != isc_info_end) {`
`176`	`176`	`short len = (short) isc_vax_integer(&result[i + 1], 2);`
`177`	`177`	`if (len != 1 && len != 2 && len != 4) {`
`178`	`178`	`goto error;`