Skip to content

Commit 651dcec

Browse files
author
drh
committed
Detect malformed nested JSONB earlier and stop rendering to avoid long
delays. FossilOrigin-Name: ab40e282465c989bf249453d7c6f60072a38b691f579411cdf9aad234b20f0f7
1 parent 3ff77c5 commit 651dcec

File tree

3 files changed

+13
-11
lines changed

3 files changed

+13
-11
lines changed

manifest

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
C Avoid\sa\spotential\sbuffer\soverread\swhen\shandling\scorrupt\sjson\sblobs.
2-
D 2024-01-29T16:49:28.555
1+
C Detect\smalformed\snested\sJSONB\searlier\sand\sstop\srendering\sto\savoid\slong\ndelays.
2+
D 2024-01-29T21:29:22.163
33
F .fossil-settings/empty-dirs dbb81e8fc0401ac46a1491ab34a7f2c7c0452f2f06b54ebb845d024ca8283ef1
44
F .fossil-settings/ignore-glob 35175cdfcf539b2318cb04a9901442804be81cd677d8b889fcc9149c21f239ea
55
F LICENSE.md df5091916dbb40e6e9686186587125e1b2ff51f022cc334e886c19a0e9982724
@@ -697,7 +697,7 @@ F src/hash.h 3340ab6e1d13e725571d7cee6d3e3135f0779a7d8e76a9ce0a85971fa3953c51
697697
F src/hwtime.h f9c2dfb84dce7acf95ce6d289e46f5f9d3d1afd328e53da8f8e9008e3b3caae6
698698
F src/in-operator.md 10cd8f4bcd225a32518407c2fb2484089112fd71
699699
F src/insert.c 3f0a94082d978bbdd33c38fefea15346c6c6bffb70bc645a71dc0f1f87dd3276
700-
F src/json.c 2bc8eeedb7ac052292c3dc795a89ca72f43e71e8156d515e12bdf4ba9bc7bbb1
700+
F src/json.c 31eb3e138661284bc561dd8d23b948126716847571d5b6e86044a284fce81cde
701701
F src/legacy.c d7874bc885906868cd51e6c2156698f2754f02d9eee1bae2d687323c3ca8e5aa
702702
F src/loadext.c 7432c944ff197046d67a1207790a1b13eec4548c85a9457eb0896bb3641dfb36
703703
F src/main.c 438b95162acfa17b7d218f586f5bde11d6ae82bcf030c9611fc537556870ad6b
@@ -2159,9 +2159,10 @@ F vsixtest/vsixtest.tcl 6a9a6ab600c25a91a7acc6293828957a386a8a93
21592159
F vsixtest/vsixtest.vcxproj.data 2ed517e100c66dc455b492e1a33350c1b20fbcdc
21602160
F vsixtest/vsixtest.vcxproj.filters 37e51ffedcdb064aad6ff33b6148725226cd608e
21612161
F vsixtest/vsixtest_TemporaryKey.pfx e5b1b036facdb453873e7084e1cae9102ccc67a0
2162-
P 3ab08ac75d97ffd9920f5c924362a4819560b40faa8a4f9100068057f5fa420a
2163-
Q +738473dc0ac353731080d0785cc7dc9810b564906c176916bd91d6cfbb1a7b18
2164-
R 05d394f6285eeb07155f6458b5abf806
2162+
P ac402cc551b2cbe3f8fbbc9c711a04942eab5eeb9d2f4a394e9370d2380427b5
2163+
Q +72f3e1d0eca2b9ebd7c4b4cdccc6d7a0173b2fdb204cb1aa207917aedab6098a
2164+
Q +97666ec052ebaceab002874d7ca5c5e6883c3d04fb7d3992235a8c4c8d08407a
2165+
R 733155be1814ed819345d16353d7d6cc
21652166
U drh
2166-
Z a8647c458acbccfab773c7d8d118b965
2167+
Z 18340cdcfaea76204a33f87984917190
21672168
# Remove this line to create a well-formed Fossil manifest.

manifest.uuid

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
ac402cc551b2cbe3f8fbbc9c711a04942eab5eeb9d2f4a394e9370d2380427b5
1+
ab40e282465c989bf249453d7c6f60072a38b691f579411cdf9aad234b20f0f7

src/json.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2269,10 +2269,11 @@ static u32 jsonTranslateBlobToText(
22692269
jsonAppendChar(pOut, '[');
22702270
j = i+n;
22712271
iEnd = j+sz;
2272-
while( j<iEnd ){
2272+
while( j<iEnd && pOut->eErr==0 ){
22732273
j = jsonTranslateBlobToText(pParse, j, pOut);
22742274
jsonAppendChar(pOut, ',');
22752275
}
2276+
if( j>iEnd ) pOut->eErr |= JSTRING_MALFORMED;
22762277
if( sz>0 ) jsonStringTrimOneChar(pOut);
22772278
jsonAppendChar(pOut, ']');
22782279
break;
@@ -2282,11 +2283,11 @@ static u32 jsonTranslateBlobToText(
22822283
jsonAppendChar(pOut, '{');
22832284
j = i+n;
22842285
iEnd = j+sz;
2285-
while( j<iEnd ){
2286+
while( j<iEnd && pOut->eErr==0 ){
22862287
j = jsonTranslateBlobToText(pParse, j, pOut);
22872288
jsonAppendChar(pOut, (x++ & 1) ? ',' : ':');
22882289
}
2289-
if( x & 1 ) pOut->eErr |= JSTRING_MALFORMED;
2290+
if( (x & 1)!=0 || j>iEnd ) pOut->eErr |= JSTRING_MALFORMED;
22902291
if( sz>0 ) jsonStringTrimOneChar(pOut);
22912292
jsonAppendChar(pOut, '}');
22922293
break;

0 commit comments

Comments
 (0)