@tus/s3-store: fix offset NaN when there are no parts (#784)

Murderlon · web-flow · commit 011ac7601282 · 2025-08-19T21:38:58.000+02:00
Closes #783
diff --git a/.changeset/nasty-drinks-itch.md b/.changeset/nasty-drinks-itch.md
@@ -0,0 +1,5 @@
+---
+"@tus/s3-store": patch
+---
+
+Fix offset being returned as `NaN` when there are no S3 parts found
diff --git a/packages/s3-store/src/index.ts b/packages/s3-store/src/index.ts
@@ -56,8 +56,7 @@ export type MetadataValue = {
 }
 
 function calcOffsetFromParts(parts?: Array<AWS.Part>) {
-  // @ts-expect-error not undefined
-  return parts && parts.length > 0 ? parts.reduce((a, b) => a + b.Size, 0) : 0
+  return parts && parts.length > 0 ? parts.reduce((a, b) => a + (b.Size ?? 0), 0) : 0
 }
 
 // Implementation (based on https://github.com/tus/tusd/blob/master/s3store/s3store.go)

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"@tus/s3-store": patch
 +---
++
 +Fix offset being returned as `NaN` when there are no S3 parts found
Original file line number	Diff line number	Diff line change
`@@ -56,8 +56,7 @@ export type MetadataValue = {`
`56`	`56`	`}`
`57`	`57`
`58`	`58`	`function calcOffsetFromParts(parts?: Array<AWS.Part>) {`
`59`		`- // @ts-expect-error not undefined`
`60`		`- return parts && parts.length > 0 ? parts.reduce((a, b) => a + b.Size, 0) : 0`
	`59`	`+ return parts && parts.length > 0 ? parts.reduce((a, b) => a + (b.Size ?? 0), 0) : 0`
`61`	`60`	`}`
`62`	`61`
`63`	`62`	`// Implementation (based on https://github.com/tus/tusd/blob/master/s3store/s3store.go)`