@tus/server: don't use AbortSignal.any to fix memory leak (#718)

Author: Murderlon

.changeset/silver-students-invent.md

@@ -0,0 +1,5 @@
+---
+"@tus/server": patch
+---
+
+Don't use AbortSignal.any to fix memory leak in older Node.js versions and to not break version support.

packages/server/src/lockers/MemoryLocker.ts

@@ -51,18 +51,23 @@ class MemoryLock implements Lock {
 
   async lock(stopSignal: AbortSignal, requestRelease: RequestRelease): Promise<void> {
     const abortController = new AbortController()
+    const onAbort = () => {
+      abortController.abort()
+    }
+    stopSignal.addEventListener('abort', onAbort)
 
-    const abortSignal = AbortSignal.any([stopSignal, abortController.signal])
-
-    const lock = await Promise.race([
-      this.waitTimeout(abortSignal),
-      this.acquireLock(this.id, requestRelease, abortSignal),
-    ])
-
-    abortController.abort()
+    try {
+      const lock = await Promise.race([
+        this.waitTimeout(abortController.signal),
+        this.acquireLock(this.id, requestRelease, abortController.signal),
+      ])
 
-    if (!lock) {
-      throw ERRORS.ERR_LOCK_TIMEOUT
+      if (!lock) {
+        throw ERRORS.ERR_LOCK_TIMEOUT
+      }
+    } finally {
+      stopSignal.removeEventListener('abort', onAbort)
+      abortController.abort()
     }
   }