Skip to content

Commit 15b9c60

Browse files
committed
Deduplicate CI runs
1 parent 093a168 commit 15b9c60

File tree

1 file changed

+6
-14
lines changed

1 file changed

+6
-14
lines changed

.github/workflows/ci.yml

Lines changed: 6 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,6 @@ on:
1313
paths-ignore:
1414
- "**.md"
1515
- ".changeset/**"
16-
pull_request:
17-
types: [opened, synchronize, reopened]
18-
paths-ignore:
19-
- "**.md"
20-
- ".changeset/**"
2116

2217
concurrency:
2318
group: ${{ github.workflow }}--${{ github.event_name == 'pull_request_target' && format('pr#{0}', github.event.pull_request.number) || github.ref }}
@@ -28,7 +23,7 @@ permissions:
2823
pull-requests: read
2924

3025
jobs:
31-
# Basic validation job - runs for all triggers without secrets
26+
# Basic validation job - runs for all PRs and pushes without secrets
3227
basic-validation:
3328
name: Build and lint
3429
runs-on: ubuntu-latest
@@ -63,14 +58,11 @@ jobs:
6358
# SECURITY: Use environment protection for external contributors only
6459
# Push events and internal PRs run without environment protection
6560
# External PRs require manual approval via 'external-testing' environment
66-
environment: ${{ github.event_name != 'push' && github.event.pull_request.head.repo.full_name != github.repository && 'external-testing' || '' }}
67-
# Run tests with secrets for:
68-
# 1. Push to main (trusted), OR
69-
# 2. PR from same repository (trusted), OR
70-
# 3. External PR (requires manual approval via environment protection)
71-
if: |
72-
github.event_name == 'push' ||
73-
github.event_name == 'pull_request_target'
61+
environment: ${{ github.event_name == 'pull_request_target' && github.event.pull_request.head.repo.full_name != github.repository && 'external-testing' || '' }}
62+
# Run tests with secrets for all triggers:
63+
# 1. Push to main (trusted)
64+
# 2. Internal PRs (trusted)
65+
# 3. External PRs (requires manual approval via environment protection)
7466

7567
steps:
7668
- name: Checkout sources

0 commit comments

Comments
 (0)