chore: Refactor to solve Implementation smells

Author: Siva-2707

src/Designite/SourceModel/SM_Method.java

@@ -103,12 +103,49 @@ public MethodDeclaration getMethodDeclaration() {
 		return methodDeclaration;
 	}
 
+	private void prepareCalledMethodsList() {
+		MethodInvVisitor invVisitor = new MethodInvVisitor(methodDeclaration);
+		methodDeclaration.accept(invVisitor);
+		List<MethodInvocation> invList = invVisitor.getCalledMethods();
+		if (invList.size() > 0) {
+			calledMethods.addAll(invList);
+		}
+	}
+
+	private void prepareInstanceOfVisitorList() {
+		InstanceOfVisitor instanceOfVisitor = new InstanceOfVisitor();
+		methodDeclaration.accept(instanceOfVisitor);
+		List<Type> instanceOfTypes = instanceOfVisitor.getTypesInInstanceOf();
+		if (instanceOfTypes.size() > 0) {
+			typesInInstanceOf.addAll(instanceOfTypes);
+		}
+	}
+
+	private void prepareParametersList(SingleVariableDeclaration var) {
+		VariableVisitor parameterVisitor = new VariableVisitor(this);
+		// methodDeclaration.accept(parameterVisitor);
+		var.accept(parameterVisitor);
+		List<SM_Parameter> pList = parameterVisitor.getParameterList();
+		if (pList.size() > 0) {
+			parameterList.addAll(pList);
+		}
+	}
+
 	private void parseParameters() {
 		for (SM_Parameter param : parameterList) {
 			param.parse();
 		}
 	}
 
+	private void prepareLocalVarList() {
+		LocalVarVisitor localVarVisitor = new LocalVarVisitor(this);
+		methodDeclaration.accept(localVarVisitor);
+		List<SM_LocalVar> lList = localVarVisitor.getLocalVarList();
+		if (lList.size() > 0) {
+			localVarList.addAll(lList);
+		}
+	}
+
 	private void parseLocalVar() {
 		for (SM_LocalVar var : localVarList) {
 			var.parse();
@@ -145,31 +182,15 @@ public void printDebugLog(PrintWriter writer) {
 	//TODO: Modularize parser with private functions
 	@Override
 	public void parse() {
-		MethodInvVisitor invVisitor = new MethodInvVisitor(methodDeclaration);
-		methodDeclaration.accept(invVisitor);
-		List<MethodInvocation> invList = invVisitor.getCalledMethods();
-		if (invList.size() > 0) {
-			calledMethods.addAll(invList);
-		}
+		prepareCalledMethodsList();
 
 		List<SingleVariableDeclaration> variableList = methodDeclaration.parameters();
 		for (SingleVariableDeclaration var : variableList) {
-			VariableVisitor parameterVisitor = new VariableVisitor(this);
-			// methodDeclaration.accept(parameterVisitor);
-			var.accept(parameterVisitor);
-			List<SM_Parameter> pList = parameterVisitor.getParameterList();
-			if (pList.size() > 0) {
-				parameterList.addAll(pList);
-			}
+			prepareParametersList(var);
 			parseParameters();
 		}
 
-		LocalVarVisitor localVarVisitor = new LocalVarVisitor(this);
-		methodDeclaration.accept(localVarVisitor);
-		List<SM_LocalVar> lList = localVarVisitor.getLocalVarList();
-		if (lList.size() > 0) {
-			localVarList.addAll(lList);
-		}
+		prepareLocalVarList();
 		parseLocalVar();
 
 		DirectAceessFieldVisitor directAceessFieldVisitor = new DirectAceessFieldVisitor();
@@ -182,14 +203,8 @@ public void parse() {
 		if (thisAccesses.size() > 0) {
 			thisAccessesInMethod.addAll(thisAccesses);
 		}
-		
-		InstanceOfVisitor instanceOfVisitor = new InstanceOfVisitor();
-		methodDeclaration.accept(instanceOfVisitor);
-		List<Type> instanceOfTypes = instanceOfVisitor.getTypesInInstanceOf();
-		if (instanceOfTypes.size() > 0) {
-			typesInInstanceOf.addAll(instanceOfTypes);
-		}
-		
+		prepareInstanceOfVisitorList();
+
 		ThrowVisitor throwVisithor = new ThrowVisitor();
 		methodDeclaration.accept(throwVisithor);
 		throwsException = throwVisithor.throwsException();

src/Designite/SourceModel/TypeInfo.java

@@ -11,6 +11,8 @@ public class TypeInfo {
 	private boolean parametrizedType;
 	private List<SM_Type> nonPrimitiveTypeParameters = new ArrayList<>();
 
+	private static final int COMMA_LENGTH = 2;
+
 	public SM_Type getTypeObj() {
 		return typeObj;
 	}
@@ -56,7 +58,7 @@ public String getStringOfNonPrimitiveParameters() {
 	}
 
 	private String removeLastComma(String str) {
-		return (str.length() > 2) ? str.substring(0, str.length() - 2) : str;
+		return (str.length() > COMMA_LENGTH) ? str.substring(0, str.length() - COMMA_LENGTH) : str;
 	}
 
 	public int getNumOfNonPrimitiveParameters() {

src/Designite/smells/implementationSmells/ImplementationSmellDetector.java

@@ -33,7 +33,7 @@ public class ImplementationSmellDetector {
 	private SourceItemInfo info;
 	private ThresholdsDTO thresholdsDTO;
 
-	private static final String ABSTRACT_FUMCTION_CALL_FROM_CONSTRUCTOR = "Abstract Function Call From Constructor";
+	private static final String ABST_FUNC_CALL_FRM_CTOR = "Abstract Function Call From Constructor";
 	private static final String COMPLEX_CONDITIONAL = "Complex Conditional";
 	private static final String COMPLEX_METHOD = "Complex Method";
 	private static final String EMPTY_CATCH_CLAUSE = "Empty catch clause";
@@ -72,7 +72,7 @@ public List<ImplementationCodeSmell> detectCodeSmells() {
 
 	public List<ImplementationCodeSmell> detectAbstractFunctionCallFromConstructor() {
 		if (hasAbstractFunctionCallFromConstructor()) {
-			addToSmells(initializeCodeSmell(ABSTRACT_FUMCTION_CALL_FROM_CONSTRUCTOR));
+			addToSmells(initializeCodeSmell(ABST_FUNC_CALL_FRM_CTOR));
 		}
 		return smells;
 	}