Draft
Conversation
charlag
force-pushed
the
crypto/android-itest
branch
2 times, most recently
from
da172a2 to
ff3e636
Compare
charlag
commented
Nov 20, 2025
| const versionCodeToWrite = `versionCode ${buildGradlePath.endsWith("kts") ? "= " : ""}${newVersionCodeString}` | ||
| const newBuildGradleString = buildGradleString.replace(new RegExp(versionRegex), versionCodeToWrite) | ||
| console.log(`Bumped Android versionCode: ${oldVersionCodeString} -> ${newVersionCodeString}`) | ||
| console.log(`Bumped Android versionCode: ${oldVersionCodeString} -> ${newVersionCodeString} (${buildGradlePath})`) |
Contributor
Author
There was a problem hiding this comment.
we should probably extract the version into the build plugin or even just gradle properties or both but it's not necessary for now
vitoreiji
force-pushed
the
crypto/android-itest
branch
2 times, most recently
from
25dd3f3 to
413d6b6
Compare
vitoreiji
force-pushed
the
crypto/android-itest
branch
2 times, most recently
from
85f997f to
48e0f22
Compare
This should prevent some confusion when "Bumped Android" appears multiple times in the log because it modified both app and calendar projects.
vitoreiji
force-pushed
the
crypto/android-itest
branch
from
48e0f22 to
fe9a990
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.