fix(api): don't log expected 401 errors

nicholaschiang · nicholaschiang · commit 5c9df64d4a5e · 2021-03-18T21:23:53.000-07:00
diff --git a/lib/api/error.ts b/lib/api/error.ts
@@ -40,8 +40,10 @@ function send(e: APIError, res: ServerResponse): void {
 }
 
 export function handle(e: unknown, res: ServerResponse): void {
-  console.error('API endpoint encountered error:', e);
+  if (!(e instanceof APIError) || e.code !== 401)
+    console.error('API endpoint encountered error:', e);
   if (e instanceof APIError) return send(e, res);
   if (e instanceof Error) return send(new APIError(e.message, 500), res);
   if (typeof e === 'string') return send(new APIError(e, 500), res);
+  return send(new APIError('Unknown error', 500), res);
 }

Original file line number	Diff line number	Diff line change
`@@ -40,8 +40,10 @@ function send(e: APIError, res: ServerResponse): void {`
`40`	`40`	`}`
`41`	`41`
`42`	`42`	`export function handle(e: unknown, res: ServerResponse): void {`
`43`		`- console.error('API endpoint encountered error:', e);`
	`43`	`+ if (!(e instanceof APIError) \|\| e.code !== 401)`
	`44`	`+ console.error('API endpoint encountered error:', e);`
`44`	`45`	`if (e instanceof APIError) return send(e, res);`
`45`	`46`	`if (e instanceof Error) return send(new APIError(e.message, 500), res);`
`46`	`47`	`if (typeof e === 'string') return send(new APIError(e, 500), res);`
	`48`	`+ return send(new APIError('Unknown error', 500), res);`
`47`	`49`	`}`