fix(request-form): show children in user select (#280)

Author: nicholaschiang

components/user/request-form.tsx

@@ -183,11 +183,13 @@ export default function RequestForm({
     ]
   );
 
-  const i18nPrefix = useMemo(() => (
-    students.length === 1 &&
-    students[0].name === 'Me' &&
-    !creating ? '' : 'for-others-'
-  ), [students, creating]);
+  const i18nPrefix = useMemo(
+    () =>
+      students.length === 1 && students[0].name === 'Me' && !creating
+        ? ''
+        : 'for-others-',
+    [students, creating]
+  );
   const messagePlaceholder = useMemo(() => {
     const studentIsMe = students.length === 1 && students[0].id === user.id;
     const studentFirstNames = join(students.map((s) => s.firstName));
@@ -208,8 +210,8 @@ export default function RequestForm({
   const userSelectQuery = useMemo(
     () =>
       org && org.members.includes(user.id)
-        ? { orgs: [org.id] }
-        : { parents: [user.id] },
+        ? { orgs: [org.id], visible: undefined }
+        : { parents: [user.id], visible: undefined },
     [org, user.id]
   );
 

lib/api/db/user.ts

@@ -140,7 +140,6 @@ export async function getUsers(
     : supabase.from<DBViewUser>('view_users');
   select = select
     .select('*', { count: 'exact' })
-    .neq('bio', '')
     .contains('tags', query.tags)
     .contains('langs', query.langs)
     .contains(
@@ -155,6 +154,7 @@ export async function getUsers(
     );
   if (typeof query.visible === 'boolean')
     select = select.eq('visible', query.visible);
+  if (query.visible === true) select = select.neq('bio', '');
   if (query.parents.length) select = select.overlaps('parents', query.parents);
   if (query.orgs.length) select = select.overlaps('orgs', query.orgs);
   // Filtering by availability shows volunteers that the student can book. In