tejas commnets

Author: Pager07

src/spam/email_checker.py

@@ -1,6 +1,7 @@
 import logging
 import re
 from html import unescape
+from openai import OpenAIError
 from typing import Optional, Union
 
 from src.render.main import MessageDef, render_email
@@ -59,7 +60,7 @@ async def check_spam(self, m: EmailSendModel):
 
         try:
             spam_result = await self.spam_service.is_spam_email(email_info, company_name)
-            # Cache all results (both spam and non-spam)
+            # Cache all results (both spam and non-spam) - only when successful
             await self.cache_service.set(m, spam_result)
 
             if spam_result.spam:
@@ -74,10 +75,10 @@ async def check_spam(self, m: EmailSendModel):
                         "email_main_body": _clean_html_body(context.get('main_message__render')) or 'no main body',
                     },
                 )
-        except Exception as e:
+        except OpenAIError as e:
             # Use the same logging structure for consistency
             logger.error(
-                "Error during spam check",
+                "LLM Provider Error during spam check",
                 extra={
                     "reason": str(e),
                     "subject": email_info.subject,

tests/conftest.py

@@ -309,8 +309,10 @@ class FakeResponse:
     # Create a fake client with a mocked responses.parse method
     fake_client = AsyncMock()
     if 'spam_service_error' in request.keywords:
-        # This will RAISE Exception when fake_client.responses.parse() is called
-        fake_client.responses.parse.side_effect = Exception('Openai test error')
+        # This will RAISE OpenAIError when fake_client.responses.parse() is called
+        from openai import OpenAIError
+
+        fake_client.responses.parse.side_effect = OpenAIError('Openai test error')
     else:
         fake_client.responses.parse.return_value = FakeResponse()